4819 manage super user roles

[Benjamin-Couey]

Resolves #4819

Description

This PR updates app/views/users/_organization_user.html.erb to show organization admins options to promote and demote other members of the organization, regardless of whether those other members are super admins. The OrganizationsController and role services were already set up to allow an org admin to promote or demote super admins, so this was the only necessary change.

This PR also updates app/views/admin/users/_roles.html.erb to avoid encountering a NoMethodError when attempting to edit a super admin. Again, the Admin::UsersController and role services correctly handled a super admin managing the org roles of another super admin.

Lastly, this PR updates _organization_user.html.erb so that super admins will always be shown an 'edit' button that takes them to the super admin facing user edit page for the sake of consistency. Previously super admins were shown this edit button in place of the 'promote user' button, but still were shown the 'demote user' button.

Regarding the potential connection to the issue #4503, while a PR for 4503 might end up modifying some of the same files, resolving issue 4819 doesn't seem to rely on resolving 4503 and vice versa. As such, this PR will made while I am still working on 4503.

Type of change

• Bug fix

How Has This Been Tested?

This was manually tested as an org admin and a super admin, verifying that both were able to manage the org roles of both normal users and super admins.

Tests were added to spec/requests/organization_requests_spec.rb to verify the promote user, demote user, and remove user actions provided by the OrganizationsController worked on users and super admins. A check that was erroneously aimed at a path handled by the Admin::OrganizationsController was also moved to the more appropriate spec/requests/admin/organizations_requests_spec.rb.

Tests were added to spec/requests/admin/users_requests_spec.rb to verify that the add role and remove role actions provided by the Admin::UsersController worked on users and super admins, as this is the interface super admins would use to manage org roles.

Tests were added to spec/system/organization_system_spec.rb and spec/system/admin/users_system_spec.rb to verify that the whole process of visiting these forms and using them to add or remove roles worked.

Screenshots

The old org user list, as viewed by an org admin

The new org user list, as viewed by an org admin

The old org user list, as viewed by a super admin

The new org user list, as viewed by a super admin

[cielf]

This is one of those cases where you don't see the flaws until you actually see what you asked for....

The "promote to admin" on the super doesn't make a lot of sense -- I guess they're a user and a superuser. But we only show the top.

Let me think about this/ discuss it with the planning group and possibly the stakeholders. I think we either should be showing all the roles, or only the top one that is linked to the organization. I'm leaning toward the latter.

FTR, this is very much an edge case -- but I want to talk about it with the core team so we can go "ok, this is what is most likely to make sense if we ever add new roles".