Skip test_rm_r_no_permissions test under root #133
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobu
reviewed
Jul 19, 2025
test/fileutils/test_fileutils.rb
Outdated
| check_singleton :rm_rf | ||
|
|
||
| return if /mswin|mingw/ =~ RUBY_PLATFORM | ||
| return if Process.uid == 0 || /mswin|mingw/ =~ RUBY_PLATFORM |
There was a problem hiding this comment.
Probably we'll need to consider capabilities as well.
Suggested change
| return if Process.uid == 0 || /mswin|mingw/ =~ RUBY_PLATFORM | |
| return if root_in_posix? |
jiajia123-wind
force-pushed
the
fix-skip-test-root
branch
2 times, most recently
from
f735182 to
955c0dc
Compare
Skip the test_rm_r_no_permissions test under the root user, as deletion always succeeds. Signed-off-by: Jiaying Song <[email protected]>
jiajia123-wind
force-pushed
the
fix-skip-test-root
branch
from
955c0dc to
3c83138
Compare
|
@nobu Thank you for your suggestion. Is this modification correct? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the test_rm_r_no_permissions test under the root user, as deletion always succeeds.