Remove RBUI mentions from codebase #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cirdes
commented
Nov 27, 2024
•
cirdes
commented
cirdes
commented
Nov 27, 2024
| @@ -2,79 +2,22 @@ Rails need a plug n play system for creating streamlined ui components. | |||
|
|
|||
| Phlex looks fun and fast, so I thought I'd start creating ui components with it. | |||
|
|
|||
| Here is the list of components that are being built. For reference, see here https://ui.shadcn.com/docs/components/accordion | |||
There was a problem hiding this comment.
That list has not been maintained
stephannv
reviewed
Nov 27, 2024
| @@ -15,12 +15,12 @@ def view_template | |||
|
|
|||
| def tailwind_config | |||
| <<~CODE | |||
| // For importing tailwind styles from rbui gem | |||
| // For importing tailwind styles from ruby_ui gem | |||
There was a problem hiding this comment.
I think this whole component can be removed, it is outdated, we don't need to check ruby_ui internal path anymore.
stephannv
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.