Include erb files in the gem so install works #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aw, I was too slow. @stephannv I discovered some other files that need to be included, too: #226 (comment) This needs to pull in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this comment, the installer looks for an erb file and it can't find it because the packaged gem doesn't include it. This simply adds
.erbfiles to what's included in the gemspec.I tried pointing my gem file at this branch and running
rails g ruby_ui:installand it managed to complete the install (though it complained abouttailwind.config.jsnot being available, since Tailwind 4 no longer uses that file by default). I used #232 to get the tailwind css config. I haven't tested that part thoroughly but it seems promising so far