Add toggle all checkbox to combobox #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karinevieira
changed the title
stephannv
reviewed
Feb 7, 2025
karinevieira
force-pushed
the
feat/add_toggle_to_combobox
branch
from
46baf0b to
3aeaa59
Compare
karinevieira
force-pushed
the
feat/add_toggle_to_combobox
branch
from
3aeaa59 to
4c7ba0c
Compare
stephannv
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a toggle target to the combobox's Stimulus controller, enabling the selection and deselection of all checkboxes. To enhance usability, I introduced a new component,
ComboboxToggleAllCheckbox, which encapsulates the controller settings.Here's a short demo:
410898836-93a0f776-737e-441f-ab39-ea1654a6c151.mov