Skip to content

pull in acceptable? optimization for varint and fix rubocop for previ… #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2017
Merged

pull in acceptable? optimization for varint and fix rubocop for previ… #356

merged 2 commits into from
Mar 2, 2017

Conversation

abrandoned
Copy link
Contributor

…ously merged PR

pulls in varint "acceptable?" check from #297

also fixes the previously merged rubocop issue in base_spec.rb

@film42

@film42
Copy link
Member

film42 commented Mar 1, 2017

Looks good. Just waiting on travis.

film42
film42 approved these changes Mar 1, 2017
View reviewed changes
Copy link
Member

@film42 film42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@abrandoned abrandoned merged commit 9326716 into master Mar 2, 2017
@abrandoned abrandoned deleted the abrandoned/optimize_acceptable_varint branch March 2, 2017 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@film42 film42 film42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abrandoned @film42