fix: preflight configured reviewers before Slack admission - #395
Merged
Conversation
ruby-dlee
force-pushed
the
fm/drop-author-gate-q6
branch
from
August 28, 2026 15:01
8e2d57f to
6cf8b57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
PR 395 is not delivery-ready until the live high-severity configured-reviewer Slack admission finding is fixed with executable behavior coverage, bounded validation runs through non-skipped test and lint, and current exact-head Crosscheck CLEAR is obtained before autonomous merge. Slack must preflight a nonempty valid configured Crosscheck reviewer roster after allowlisted live-head resolution but before request metering, start acknowledgement, reaction, or review execution; missing/invalid roster must visibly refuse without consuming request capacity or starting review. Authorship, model/account origin, branch, worktree, checkout lineage, task metadata, and launch records remain non-gating historical inputs. Preserve live non-draft merge requirements, exact-head CLEAR, CI/currentness, and atomic expected-head merge.
What Changed
Risk Assessment
Testing
The configured baseline command had already passed; I then ran the focused Slack behavior suite and an end-to-end Slack admission exercise showing a missing configured reviewer is visibly refused before metering/reaction/review startup, while a valid configured reviewer proceeds to exact-head CLEAR.
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
if [ "${FM_AZURE_VALIDATION_CELL:-0}" = 1 ]; then exec "$FM_AZURE_VALIDATION_SHARD_BRIDGE" behavior --count "${FM_AZURE_VALIDATION_SHARD_COUNT:-8}"; else exec bin/fm-no-mistakes-test-command.sh; fitests/fm-crosscheck-slack.test.shpython3 /tmp/no-mistakes-worker-evidence-1117159427/slack_admission_e2e.py✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.