fix(crosscheck): use provider-valid verdict repair effort - #335
Merged
Conversation
ruby-dlee
force-pushed
the
fm/crosscheck-verdict-effort-r9
branch
from
August 25, 2026 19:34
6cf9cc7 to
1136611
Compare
ruby-dlee
force-pushed
the
fm/crosscheck-verdict-effort-r9
branch
from
August 25, 2026 21:10
1136611 to
c0973c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Fix the released PR 333 verdict-repair incompatibility that blocks PR 327's exact-head Azure Crosscheck. The exact live failure was at PR 327 head 85f89f8: the primary model review completed at xhigh, then the one bounded verdict repair sent reasoning_effort=minimal and direct Fireworks rejected that literal because it accepts low, medium, high, xhigh, max, none, adaptive, integer, or boolean. Reproduce the failure through deterministic adapter/guest tests, identify one owner of repair effort, and make the smallest provider-valid correction. Do not lower the primary xhigh review, weaken schema or evidence gates, add retries, change PR 327 source, touch cloud-result-return files, or invoke another paid review of PR 327. Preserve exactly one bounded fresh repair and terminal telemetry. Add a regression that fails on literal minimal and executes the production command-building/parser path. Validate focused Crosscheck and Azure model-compartment tests, lint, compilation, and docs, then open a green PR and obtain exact-head Crosscheck for that new PR. PR 327's owner will restart its already-authorized review only after this correction lands and deploys.
What Changed
lowreasoning effort for the single bounded Pi verdict-repair attempt while preserving the primary review effort.lowinstead ofminimal.Risk Assessment
✅ Low: Captain, the change is narrowly scoped, preserves the primary xhigh review and single bounded repair, and exercises the production command-building/parser path with provider-valid low effort.
Testing
The previously successful baseline plus the focused Azure Crosscheck suite and a deterministic production-path replay all passed; reviewer-visible evidence confirms xhigh primary effort, exactly one low-effort repair, successful verdict parsing, and preserved terminal telemetry.
Evidence: Deterministic end-to-end verdict-repair transcript
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
if [ "${FM_AZURE_VALIDATION_CELL:-0}" = 1 ]; then exec "$FM_AZURE_VALIDATION_SHARD_BRIDGE" behavior --count "${FM_AZURE_VALIDATION_SHARD_COUNT:-8}"; else exec bin/fm-no-mistakes-test-command.sh; fiBaseline configured test command (reported as already successful by the outer executor).tests/fm-crosscheck-azure.test.shExecuted the regression’s deterministic fake-provider harness throughbin/fm-crosscheck-pi-reviewer.pyandbin/fm-crosscheck-pi-verdict-extension.tsusingterminal-error-then-valid, then emitted the captured command efforts, verdict, and telemetry.git status --shortto confirm testing left no worktree artifacts.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.