fix: continue Pi session for verdict repair - #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Make Azure Crosscheck recover a Pi output-length or malformed verdict attempt by continuing the same isolated exact-head review session for one short verdict-only retry, while preserving cleanup, telemetry, and fail-closed semantics.
What Changed
Risk Assessment
✅ Low: The change is narrowly scoped and preserves isolation, bounded single-retry behavior, telemetry aggregation, cleanup, and fail-closed handling while continuing the same Pi session for verdict repair.
Testing
The successful baseline was supplemented with focused executable Pi CLI simulations demonstrating same-session recovery from malformed and output-length attempts, cumulative telemetry, preserved isolation, and fail-closed behavior after exactly one repair; all checks passed and the worktree remained clean.
Evidence: Pi verdict repair and fail-closed transcript
PI RUNTIME repairs one verdict-protocol miss, then fails closed PASS the digest-bound Pi runtime bounds verdict repair and remains fail closedPipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
🔧 **Test** - 1 issue found → auto-fixed ✅
if [ "${FM_AZURE_VALIDATION_CELL:-0}" = 1 ]; then exec "$FM_AZURE_VALIDATION_SHARD_BRIDGE" behavior --count "${FM_AZURE_VALIDATION_SHARD_COUNT:-8}"; else exec bin/fm-no-mistakes-test-command.sh; fi🔧 Fix: Stabilize Herdr heartbeat readiness test
✅ Re-checked - no issues remain.
if [ "${FM_AZURE_VALIDATION_CELL:-0}" = 1 ]; then exec "$FM_AZURE_VALIDATION_SHARD_BRIDGE" behavior --count "${FM_AZURE_VALIDATION_SHARD_COUNT:-8}"; else exec bin/fm-no-mistakes-test-command.sh; fiConfigured baseline command (reported as already successful):if [ "${FM_AZURE_VALIDATION_CELL:-0}" = 1 ]; then exec "$FM_AZURE_VALIDATION_SHARD_BRIDGE" behavior --count "${FM_AZURE_VALIDATION_SHARD_COUNT:-8}"; else exec bin/fm-no-mistakes-test-command.sh; fiExecuted the focusedpi_reviewer_runtime_unitharness againstbin/fm-crosscheck-pi-reviewer.py, covering valid submission, internal retry, malformed verdict recovery, same-session continuation, minimal-effort verdict-only retry, telemetry aggregation, and bounded failures.Repeated the focused executable harness withlengthincluded among exhausted-repair scenarios, proving both length-stop recovery and failure after one unsuccessful retry.Verifiedgit status --shortremained clean after testing.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.