fix(crosscheck): support credentialless private PR evidence - #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Repair Azure Crosscheck so exact private pull request evidence works credentiallessly across macOS and Linux, ship the repair, and leave Relvino PR 1476 uncleared until its exact-head retry returns an admitted verdict.
What Changed
Risk Assessment
✅ Low: The credentialless private-bundle path is bounded by exact commit, ancestry, tree, bundle digest, and size checks; the portable askpass fix is behaviorally covered, and Relvino PR 1476 remains open.
Testing
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 1 issue found → auto-fixed ✅
tests/fm-azure-runner.test.sh:186- This modified assertion only counts an implementation-source substring, so it violates the test-quality rule and will break on behavior-preserving refactors. Remove it; the private snapshot preparation tests already exercise the source-binding behavior through the executable interface.🔧 Fix: Remove brittle assertion and repair ancestor fixture
✅ Re-checked - no issues remain.
⏭️ **Test** - skipped
Step was skipped.
✅ **Document** - passed
✅ No issues found.
⏭️ **Lint** - skipped
Step was skipped.
✅ **Push** - passed
✅ No issues found.