fix: bind Azure receipts to exact review evidence - #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Get the regular GLM 5.2 Azure Crosscheck lane up and working reliably for Firstmate without overbuilding day-one enterprise machinery. Preserve exact-head review evidence, model-family independence, credential isolation, fail-closed cloud cleanup, and the trusted host and Azure VM identity bindings. Fix the live failure where a credentialless Azure evidence VM was required to echo private paths belonging to the separate model VM, even though those paths were already independently host-bound and copying them into a receipt proved nothing. Keep the remote receipt bound to its distinctive marker and exact base and head SHAs, leave local reviewer receipts unchanged, add behavioral regression coverage and concise operator documentation, use no Bugbot, and ship through green CI. Focused Crosscheck tests, the full Azure contract suite, and the complete repository lint already passed before this run, so duplicate local test and lint stages are intentionally skipped while CI remains required.
What Changed
Risk Assessment
✅ Low: The change is narrowly scoped and preserves local receipt identity checks while making Azure receipts bind only the distinctive marker and exact base/head SHAs; model identity, credential isolation, exact-head evidence, and fail-closed cleanup remain independently enforced.
Testing
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
⏭️ **Test** - skipped
Step was skipped.
✅ **Document** - passed
✅ No issues found.
⏭️ **Lint** - skipped
Step was skipped.
✅ **Push** - passed
✅ No issues found.