ci: split behavior coverage between local validation and required CI - #323
Merged
Conversation
ruby-dlee
force-pushed
the
fm/fm-validation-local-ci-split-k2
branch
from
August 24, 2026 23:48
5077cb9 to
c8c8267
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Update PR 323 onto current main including merged PR 325, then run the normal bounded validation path. Preserve the complete 123-file required-CI behavioral coverage union while keeping ordinary local validation at or below 15 minutes and local-plus-required-CI evidence at or below 30 minutes. Do not spend Azure budget, weaken any behavior family or seal, modify Crosscheck code/config/deployment, or merge the PR. The ordinary local path must remain the registry-derived serial herdr-lab/herdr-mixed set through tests/run.sh plus locked Agent Fleet pytest and compileall, while required GitHub Behavior tests retain the full eight-runner inventory including all hermetic bodies and the mixed-file hermetic portion.
What Changed
herdr-labandherdr-mixedtests through one serialtests/run.shinvocation, followed by locked Agent Fleet pytest and compileall checks.Risk Assessment
✅ Low: The change is narrowly scoped and preserves the required registry-derived serial local Herdr set, locked Agent Fleet checks, and the existing eight-runner required-CI coverage union without modifying Crosscheck or Azure deployment behavior.
Testing
The successful baseline exercised the normal local path; focused executable contracts then verified registry-derived serial Herdr selection, locked package commands, remote fail-closed behavior, and the complete disjoint 123-file eight-runner CI union. CLI logs provide reviewer-visible evidence; no screenshot was appropriate because this is a shell/CI workflow change.
Evidence: 123-file eight-shard inventory and timing plan
Evidence: Behavior shard execution and union contract
Evidence: Local registry-derived and remote split contract
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
if [ "${FM_AZURE_VALIDATION_CELL:-0}" = 1 ]; then exec "$FM_AZURE_VALIDATION_SHARD_BRIDGE" behavior --count "${FM_AZURE_VALIDATION_SHARD_COUNT:-8}"; else exec bin/fm-no-mistakes-test-command.sh; fiBaseline configured command already completed successfully:if [ "${FM_AZURE_VALIDATION_CELL:-0}" = 1 ]; then exec "$FM_AZURE_VALIDATION_SHARD_BRIDGE" behavior --count "${FM_AZURE_VALIDATION_SHARD_COUNT:-8}"; else exec bin/fm-no-mistakes-test-command.sh; fitests/run.sh "$PWD/tests/fm-behavior-shards.test.sh"tests/run.sh "$PWD/tests/fm-azure-runner.test.sh"bin/fm-behavior-shards.sh --check 8Compared executable behavior, duration, and capability inventories at target commite67ff0df9f26192999a0e75feaf55500100c3978; each contains exactly 123 files/rows, with 9 herdr-lab, 1 herdr-mixed, and 113 hermetic entries.Checked the duration-balanced plan: the longest estimated required-CI shard is 513,730 ms (8.56 minutes), supporting the bounded local-plus-required-CI contract.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.