fix(azure): recover terminal worker claims - #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
This repairs terminal Azure worker execute claims that cannot be replayed or released under the old resource classification.
Why
The live slot 2 claim recorded its task Run Command while its provisioning state was
Succeeded. That same per-execution resource was rewritten and later endedFailed, but its fallback immutable identity is the provisioning-state string. Both provider replay and lifecycle classification therefore treated a status transition as a foreign resource identity, permanently blocking replay, release, and reset.The terminal probe avoids a forced guest rerun while preserving exact execution identity. The structured identity-refusal channel is intentionally narrow: throttles, deallocated compute, landed-code failures, malformed results, tag mismatches, and other ordinary provider errors still retain the claim.
Verification
tests/run.sh tests/fm-worker-lifecycle.test.shtests/run.sh tests/fm-worker-outcome-transport.test.sh tests/fm-azure-pilot.test.shbin/fm-lint.shThe lifecycle fixture covers transient-refusal retention, terminal reconcile-retain then abandon-clear, exact identity-refusal abandonment, successful-result recovery, stale-script refusal, all-resource foreign identity matrices in provider and lifecycle, and the complete ordinary deallocate, delete-compute, reset release ladder. Mutation pins cover the five required safety boundaries.
No live worker claim or Azure resource is changed by this PR. Recovery begins only from merged main after exact-head review and CI are green.