fix(crosscheck): retry malformed Azure Pi artifacts - #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Azure Pi reviews now allow one clean output-protocol correction when Pi exits zero with a safely completed stream but returns an empty, malformed, non-object, or incomplete outer artifact.
The adjacent Azure guide now records all four discarded PR #285 live attempts and the unproven status of this one-shot correction.
Why
After the fenced-verdict parser and exact wrapper-schema fixes landed, two live PR #285 compartment attempts still returned prose-only final text. Both were correctly discarded. This narrow retry gives Pi one output-only correction inside the same credentialed compartment without broadening provider, stream, identity, schema, or attempt-count acceptance.
Verification
tests/run.sh tests/fm-crosscheck-azure.test.shtests/run.sh tests/fm-crosscheck.test.shbin/fm-lint.sh(251 scripts)The executable regression extracts the exact shipped Pi branch. It covers valid-first, corrected prose/incomplete/non-object artifacts, provider and terminal failures without retry, hostile control-laden stderr, oversized artifacts, second-attempt process failure, stale-result removal, exact retry arguments and generation, schema-last prompt construction, no prior-output feedback, and the two-call ceiling.
No Azure action is part of this PR. The live PR #285 review will be retried only after this change is reviewed, green, and merged.