fix: wake native away mode on captain-relevant events - #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Fix the Claude away-mode overnight escalation wedge in one single-concern PR, with a postmortem committed before the implementation. Preserve bash triage and batching so routine wakes remain token-free, but deliver captain-relevant needs-decision, ready-to-merge, and failure events by completing Claude's native tracked background task instead of typing into the composer. Keep state/.wake-queue as the lossless backlog, remove pane busy/composer guards from native delivery, retain honest legacy compatibility semantics, update the /afk skill and AGENTS.md section 8, and prove in isolated regression tests that native delivery succeeds under the old false-defer conditions. Hold the PR for captain merge and do not merge it.
What Changed
Risk Assessment
✅ Low: Captain, the change is focused, preserves the durable wake backlog and legacy delivery path, and conforms to the stated native-delivery requirements without source-verifiable defects.
Testing
The supplied full baseline already passed; focused regressions and an isolated three-event runtime scenario also passed with CLI transcripts captured, and final cleanup left the worktree clean. No screenshot was applicable to this non-UI shell behavior.
Evidence: All escalation classes batched through native delivery
Evidence: Focused false-defer regression transcript
Evidence: Reproducible multi-event evidence harness
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; uv run --directory tools/agent-fleet --locked pytest || rc=1; uv run --directory tools/agent-fleet --locked python -m compileall -q src || rc=1; exit "$rc"Pre-supplied successful baseline:command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; uv run --directory tools/agent-fleet --locked pytest || rc=1; uv run --directory tools/agent-fleet --locked python -m compileall -q src || rc=1; exit "$rc"bash tests/fm-afk-reap-wake-e2e.test.shcaptured viascriptbash tests/fm-daemon.test.shbash …/native-reap-wake-all-events.sh <worktree>captured viascriptgit diff-tree --no-commit-id --name-only -r bda8705and ordered base-to-targetgit logFinalgit status --short --untracked-files=alland transient test-directory scan✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.