feat: add private memory hygiene discipline - #17
Merged
Conversation
ruby-dlee
force-pushed
the
fm/memory-hygiene-m8
branch
from
July 22, 2026 15:33
5ea5640 to
5468e86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Build Firstmate's memory-hygiene discipline so private data/captain.md and data/learnings.md stay lean and robust. Add a tight agent-only internal skill, roughly 60-80 lines, that owns per-entry rule-or-fact-only essence, strips emotional or dramatic incident narrative, permits at most a one-line example or pointer, deduplicates into one owner, and applies inspect-then-update with in-place pruning; include a concise before/after example. Sharpen only AGENTS.md section 6's two private-memory routing rows plus a one-line pointer, and add the matching section 13 load trigger. Keep routing, stow behavior, and repository-wide one-owner guidance with their existing owners, do not duplicate the full standard into AGENTS.md, do not touch the actual gitignored private memory files, and keep the diff single-concern. Ship a PR but do not merge it.
What Changed
data/captain.mdanddata/learnings.md.Risk Assessment
✅ Low: The change is narrowly scoped and satisfies the source-verifiable intent: it adds a 67-line internal memory-hygiene skill, preserves existing ownership boundaries, updates only the permitted AGENTS.md locations, and does not touch private memory files.
Testing
The already-green full baseline was supplemented with the focused stow regression and an end-to-end trigger-to-curated-memory acceptance check; the 67-line internal skill, ownership boundaries, single-concern scope, and untouched private-memory files all passed, with Markdown evidence captured instead of a screenshot because this is a non-UI agent-instruction change.
Evidence: Memory-hygiene end-to-end evidence
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; uv run --directory tools/agent-fleet --locked pytest || rc=1; uv run --directory tools/agent-fleet --locked python -m compileall -q src || rc=1; exit "$rc"Harness-provided successful baseline:command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; uv run --directory tools/agent-fleet --locked pytest || rc=1; uv run --directory tools/agent-fleet --locked python -m compileall -q src || rc=1; exit "$rc"bash tests/fm-stow-contract.test.shCommit-level acceptance shell check for skill length/metadata, rule-or-fact essence, anti-narrative guidance, one-line example-or-pointer limit, deduplication, in-place pruning, section 6/13 triggers, unchanged stow and one-owner guidance, two-file scope, and absence of private-memory changesManual review ofbf7c5ad167514cba879cb095c091fe1627549ccc..5ea5640d9f03e660cf6ff87d8c7c63246a4cd015and the rendered trigger → skill → curated-result evidencegit status --shortafter testing✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.