Add more detection patterns on Rails/ResponseParsedBody
#1571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added detection patterns to correctly detect some of Nokogiri's aliases as well.
JSON.parse(response.body)Nokogiri::HTML(response.body)Nokogiri::HTML4(response.body)Nokogiri::HTML5(response.body)Nokogiri::HTML.parse(response.body)Nokogiri::HTML4.parse(response.body)Nokogiri::HTML5.parse(response.body)Nokogiri::HTML::Document.parse(response.body)Nokogiri::HTML4::Document.parse(response.body)Nokogiri::HTML5::Document.parse(response.body)Note: The originally supported
Nokogiri::HTMLcorresponds toNokogiri::HTML4, so both HTML4 and HTML5 were originally detected. See docs about more details:Additionally, I simplified the offense message. This was done out of concern that optimizing the message might complicate the code, given the increased scope of this implementation.