Skip to content

Conversation

ushi-as
Copy link

@ushi-as ushi-as commented Aug 21, 2025

The default include patterns also matched folders outside the current working directory. When my app lives in /srv/app the pattern **/app/**/*.rb also matches the file spec/rails_helper.rb, because the absolute path (/srv/app/spec/rails_helper.rb) matches the pattern. This is unintended. The PR ensures that only app folders inside the projects directory are recognized.

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

@ushi-as ushi-as force-pushed the fix-default-include-patterns branch from 3085107 to 2a2bbc5 Compare August 21, 2025 10:50
@ushi-as ushi-as force-pushed the fix-default-include-patterns branch from 2a2bbc5 to 5977336 Compare August 21, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant