Make Rails/EnvironmentComparison aware of Rails.env.to_sym
          #1481
        
          
      
      
        
          +121
        
        
          −48
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Adds support for
Rails.env.to_symtoRails/EnvironmentComparisoncop. Code like:will be registered as an offense and autocorrected to:
Rails.env.to_symis used relatively commonly, and there are some examples of it being used to check the current env, so I think this is a worthwhile addition to the cop.If this PR is accepted,
Rails/UnknownEnvshould also be updated to supportRails.env.to_sym.Lastly, I took the opportunity to refactor the cop a bit. Let me know if it's too much for this PR and I'll revert the changes.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.