Skip to content

rubocop-lts/Style-TrailingCommaInArguments

Repository files navigation

Style::TrailingCommaInArguments

Please ignore the casing of the filenames in this gem. I ran the command bundle gem ... with the name of the cop that was failing, and thought I might accomplish two experiments here at once. I just wanted to see how it would work with wildly unconventional filenames, while also trying to repro the bug. I know, I know, only test one subject at a time... I think the finding is valid in spite of the odd casing.

About the bug

When running RuboCop on a project I saw the following errors:

2 errors occurred:
An error occurred while Style/TrailingCommaInArguments cop was inspecting /IdeaProjects/kettle-soup-cover/kettle-soup-cover.gemspec:52:15.
An error occurred while Style/TrailingCommaInArguments cop was inspecting /IdeaProjects/kettle-soup-cover/kettle-soup-cover.gemspec:59:26.

Errors are usually caused by RuboCop bugs.
Please, update to the latest RuboCop version if not already in use, and report a bug if the issue still occurs on this version.
https://github.com/rubocop/rubocop/issues

Mention the following information in the issue report:
1.75.4 (using Parser 3.3.8.0, rubocop-ast 1.44.1, analyzing as Ruby 2.7, running on ruby 3.4.2) [x86_64-linux]

The code at those specific lines was:

  spec.files = Dir[
    "lib/**/*.rb",
    "lib/**/rakelib/*.rake",
    "sig/**/*.rbs",
  ]

and

  spec.extra_rdoc_files = Dir[
    "CHANGELOG.md",
    "CODE_OF_CONDUCT.md",
    "CONTRIBUTING.md",
    "LICENSE.txt",
    "README.md",
    "SECURITY.md",
  ]

In both cases the error pointed to the D in Dir on the first line of each.

In narrowing down the culprit of the bug I found that it was triggered by rubocop-shopify, not rubocop.

I was able to create a reproduction of the bug in this repository using the latest 2.x release of the rubocop-shopify gem. The bug does not occur with vanilla rubocop. The bug has been fixed in Shopify's main branch which is targeting the not-yet-released v3.0! Unless a new release of the 2.x line is planned this probably doesn't need further review.

About

Bug Repro Attempt

Resources

License

Code of conduct

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published