pntpos: pass in the receiver index; and antpos fix #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass in the receiver index, as a 'base' argument, which is 0 for the rover and 1 for the base, to allow the respective options to be selected rather than just using the rover options even for the base. Start making use of this: in rescode() this is now used to select the respective SNR and SNR mask. For postpos.c where a one based receiver number and zero base index were both be used, fix an instance in antpos() of indexing into option anttype[] with an one base index which would be OOB for a value of 2. Try to clean up this code in this regard.
ourairquality
force-pushed
the
pntpos-base-rov
branch
from
bc1c918 to
8309ec8
Compare
|
Moved to #533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite to applying the antenna delta for the pntpos solutions - need to know if the base or rover delta is to be applied. Also fixes an OOB in rtkpos.c.
Pass in the receiver index, as a 'base' argument, which is 0 for the rover and 1 for the base, to allow the respective options to be selected rather than just using the rover options even for the base. Start making use of this: in rescode() this is now used to select the respective SNR and SNR mask.
For postpos.c where a one based receiver number and zero base index were both be used, fix an instance in antpos() of indexing into option anttype[] with an one base index which would be OOB for a value of
2. Try to clean up this code in this regard.