feat(json): add TOON encoding to preserve all JSON values (#621, #827)#863
Open
voska wants to merge 1 commit intortk-ai:developfrom
Open
feat(json): add TOON encoding to preserve all JSON values (#621, #827)#863voska wants to merge 1 commit intortk-ai:developfrom
voska wants to merge 1 commit intortk-ai:developfrom
Conversation
47c290c to
f316211
Compare
Contributor
|
Hey We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes No logic changes — only file moves and import path updates. What you need to doRebase your branch on git fetch origin && git rebase origin/developGit detects renames automatically. If you get import conflicts, update the paths: use crate::git; // now: use crate::cmds::git::git;
use crate::tracking; // now: use crate::core::tracking;
use crate::config; // now: use crate::core::config;
use crate::init; // now: use crate::hooks::init;
use crate::gain; // now: use crate::analytics::gain;Need help rebasing? Tag @aeppling |
…rtk-ai#827) RTK's json_cmd strips values from JSON arrays >5 items, showing only the first item. Multiple P0/P1 issues document user pain from silent data loss (rtk-ai#621, rtk-ai#827, rtk-ai#690, rtk-ai#488). TOON (Token-Oriented Object Notation) encodes JSON 22-59% smaller while preserving ALL values. LLM benchmarks show 76.4% accuracy vs JSON's 75.0%. For a 50-row dataset: Raw JSON: 4,214 bytes (all data) TOON: 1,963 bytes (all data, 53% smaller) RTK compact (old): 142 bytes (1 item shown, 0% data) Changes: - Add toon-rust crate for JSON-to-TOON encoding - New toon_convert module with budget-enforced conversion - json_cmd: try TOON before compact_json in data mode - curl_cmd: try TOON before schema extraction - 16KB byte budget (~4,000 tokens) with line-boundary truncation - RTK_NO_TOON=1 env var to disable - Schema mode (--schema) unchanged
f316211 to
2959d53
Compare
Author
|
Rebased and moved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json_cmdandcurl_cmdnow try TOON encoding before compact/schema extractionRTK_NO_TOON=1disables, falling back to existing behaviortoon_convertmodule: 1 public function, 9 testsBefore (6-item array):
After:
142 bytes / 0% data → 120 bytes / 100% data.
Addresses #621 (JSON filter strips all values), #827 (silent truncation trust loss), #690 (over-compression causing 3x agent cost), #488 (no middle ground between aggressive and off).
Test plan
cargo fmt --all && cargo clippy --all-targets && cargo test— 1123 passed, 0 warningsecho '[6 items]' | rtk json -shows all items as TOONRTK_NO_TOON=1restores old compact behavior--schemamode unchanged