feat(kubectl): add global context and identity flags (#857)#858
Open
pszymkowiak wants to merge 1 commit intodevelopfrom
Open
feat(kubectl): add global context and identity flags (#857)#858pszymkowiak wants to merge 1 commit intodevelopfrom
pszymkowiak wants to merge 1 commit intodevelopfrom
Conversation
Add KubectlGlobalArgs struct with --context, --kubeconfig, -n, -l, --as flags shared across all kubectl subcommands (pods, services, logs). These flags are forwarded to the underlying kubectl command. Essential for multi-cluster workflows where --context and -n are used on every command. Based on PR #426 by @jordi-murgo, rebased on develop. Also fixes pre-existing clippy warning in rake_cmd.rs. 1126 tests passed, 0 failed. Signed-off-by: Patrick szymkowiak <patrick.szymkowiak@innovtech.eu>
Contributor
|
Hey We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes No logic changes — only file moves and import path updates. What you need to doRebase your branch on git fetch origin && git rebase origin/developGit detects renames automatically. If you get import conflicts, update the paths: use crate::git; // now: use crate::cmds::git::git;
use crate::tracking; // now: use crate::core::tracking;
use crate::config; // now: use crate::core::config;
use crate::init; // now: use crate::hooks::init;
use crate::gain; // now: use crate::analytics::gain;Need help rebasing? Tag @aeppling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
KubectlGlobalArgsstruct with global kubectl flags shared across all subcommands:--context--kubeconfig-n/--namespace-l/--selector--asThese flags now work on
rtk kubectl pods,rtk kubectl services, andrtk kubectl logs.Example:
rtk kubectl pods --context prod -n api -l app=webBased on PR #426 by @jordi-murgo (inactive since March 9), rebased on develop.
Closes #857 (partial — global flags done, TOML filters for describe/apply/top still needed).
Test plan