fix(npx): route unknown tools through npx instead of npm#840
Open
gghez wants to merge 1 commit intortk-ai:developfrom
Open
fix(npx): route unknown tools through npx instead of npm#840gghez wants to merge 1 commit intortk-ai:developfrom
gghez wants to merge 1 commit intortk-ai:developfrom
Conversation
Contributor
|
Hey We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes No logic changes — only file moves and import path updates. What you need to doRebase your branch on git fetch origin && git rebase origin/developGit detects renames automatically. If you get import conflicts, update the paths: use crate::git; // now: use crate::cmds::git::git;
use crate::tracking; // now: use crate::core::tracking;
use crate::config; // now: use crate::core::config;
use crate::init; // now: use crate::hooks::init;
use crate::gain; // now: use crate::analytics::gain;Need help rebasing? Tag @aeppling |
8a53e04 to
737f72a
Compare
Author
|
Thanks for the heads up — rebased and updated the import paths to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk npx <unknown-tool>was dispatching tonpminstead ofnpxbecause thecatch-all in the Npx match arm delegated to
npm_cmd::run(), which hardcodesresolved_command("npm")npxinvocation that still applies npmboilerplate filtering via
filter_npm_outputTest plan
cargo fmt --all && cargo clippy --all-targets && cargo testrtk npx cowsay hellooutput inspectedFixes #815