Replace lazy_static with std::sync::LazyLock

[jbgriesner]

Replaces all uses of the lazy_static crate with std::sync::LazyLock, which has been stable since Rust 1.80.

Motivation:

• Removes one external dependency (lazy_static = "1.4")
• Uses std

No behavior change. LazyLock initializes on first access, exactly like lazy_static. All regex patterns remain identical.

[FlorianBruniaux]

Hi @jbgriesner, the migration is mechanically correct across all 14 files and the motivation is solid: one fewer external dependency, aligned with the standard library since Rust 1.80.

Two things needed before merge:

1. std::sync::LazyLock stabilized in Rust 1.80 (July 2024). Please add rust-version = "1.80" to Cargo.toml so anyone on an older toolchain gets a clear error instead of a cryptic compile failure.

2. CI shows 0/0 checks. Could you check why the workflow isn't triggering? We need cargo fmt --all && cargo clippy --all-targets && cargo test to pass before merge.

Minor note: next_cmd.rs and playwright_cmd.rs keep the statics inside function bodies. This is valid Rust but inconsistent with every other module in the codebase after this PR. Worth moving to module level for uniformity, though it's not a blocker.

[FlorianBruniaux]

Hey @jbgriesner, heads up: PR #349 (TOML filter DSL) uses lazy_static\! in src/toml_filter.rs. If your LazyLock migration merges first, we'll switch to LazyLock directly — cleaner result. No action needed from you, just FYI.

[jbgriesner]

2. CI shows 0/0 checks. Could you check why the workflow isn't triggering? We need cargo fmt --all && cargo clippy --all-targets && cargo test to pass before merge.

The 0/0 CI checks are a GitHub limitation with fork PRs: workflows run from the fork's own .github/workflows/ directory, not from the upstream repo. Since my fork doesn't replicate the upstream CI setup, no checks trigger automatically.

I've verified locally that all three gates pass: cargo fmt --all && cargo clippy --all-targets && cargo test
430 tests pass, no clippy errors.

[CLAassistant]

All committers have signed the CLA.

[pszymkowiak]

Hi! Two things needed before we can review:

1. Retarget to develop — this PR targets master, but all PRs should target develop. You can change the base branch in the PR settings (right sidebar).
2. Sign the CLA — if not already done, please sign at https://cla-assistant.io/rtk-ai/rtk

Thanks!

[aeppling]

Hey

We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes src/ from a flat layout into subfolders.

No logic changes — only file moves and import path updates.

What you need to do

Rebase your branch on develop when receiving this comment:

git fetch origin && git rebase origin/develop

Git detects renames automatically. If you get import conflicts, update the paths:

use crate::git;        // now: use crate::cmds::git::git;
use crate::tracking;   // now: use crate::core::tracking;
use crate::config;     // now: use crate::core::config;
use crate::init;       // now: use crate::hooks::init;
use crate::gain;       // now: use crate::analytics::gain;

Need help rebasing? Tag @aeppling