Automatically rebuild if *any* file changes #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this commit, the auto rebuilder would only rebuild individual files that have been changed. However, HAML/SCSS/SASS files can have import dependencies on eachother. Modifying a file which is a dependency of another file did not cause dependent file to rebuild, meaning that the emitted resources did not stay up to date. Ideally, the builder would be capable of tracking import dependencies and only rebuilding the minimal set of files necessary to satisfy updates anywhere in the dependency chain. However, this is impossible to do correctly without detailed integration with the underlying rendering engine. In the absence of this ideal solution, this commit modifies to auto-builder to rebuild *all* files, if *any* files have changed. Due to the speed of compilation in the common case, this shouldn't cause any problems, and ensures thatthe auto-builder is still useful even when modifying dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this commit, the auto rebuilder would only rebuild
individual files that have been changed. However, HAML/SCSS/SASS files
can have import dependencies on eachother. Modifying a file which is
a dependency of another file did not cause dependent file to rebuild,
meaning that the emitted resources did not stay up to date.
Ideally, the builder would be capable of tracking import dependencies
and only rebuilding the minimal set of files necessary to satisfy
updates anywhere in the dependency chain. However, this is impossible to
do correctly without detailed integration with the underlying rendering
engine.
In the absence of this ideal solution, this commit modifies the
auto-builder to rebuild all files, if any files have changed. Due to
the speed of compilation in the common case, this shouldn't cause any
problems, and ensures that the auto-builder is still useful even when
modifying dependencies.