Allow built-in IPv{4,6}Address objects when constructing A/AAAA rdata
#1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwelling
requested changes
Mar 7, 2025
Also applies elsewhere where dns.rdata.Rdata._as_ipv{4,6}_address is
used.
This now returns a better error message. Previously: `SyntaxError: 'foo' object has no attribute 'get'` Now: `ValueError: tok must be a string or a Tokenizer`
balaziks
force-pushed
the
rdtypes_a_aaaa_builtin_ipaddress
branch
from
3f3f850 to
b49aec8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support of Python's built-in
ipaddress.IPv{4,6}Addresstypes for constructingRdataof typeAandAAAA. This also adds support in other placesdns.rdata.Rdata._as_ipv{4,6}_addressclass method is used.In testing this I also encountered a cryptic error message from
dns.rdata.from_textwhich I improved to be more specific.