Repository navigation
fix(blocks): keep GoDAM media blocks robust in flex & narrow containers #2234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KMchaudhary
wants to merge
7
commits into
develop
Choose a base branch
from
fix/pdf-block-flex-layout-width
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b445a57
fix(pdf-block): fill container width so flex layouts don't collapse
c37d2a6
feat(pdf-block): make card view respond to container width, not viewport
629aa6c
feat(pdf-block): mirror card container-query stacking in the block ed…
edd12bb
style(pdf-block): lower card stack breakpoint to 400px container width
c01a0de
fix(audio,video-thumbnail): fill container width so flex layouts don'…
0cb5b5d
fix(blocks): fill width only in flex parents, and keep floats out of …
2fb317e
fix(pdf-block): still stack a floated card on phones
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same issue as the comment on
godam-pdf/style.scss. With Align: Full width this block now spans 0 to 1340 px instead of 0 to 1440 px (1440 px window, 50 px side padding). With a 40 px left margin in a column it ends 40 px past the column (760 px instead of 720 px). Scoping the width keeps the Row/Stack fix (590 / 645 px) and puts both cases back to develop: