Keep the Gravity Forms recorder working after an AJAX page change by subodhr258 · Pull Request #2217 · rtCamp/godam

subodhr258 · 2026-10-19T10:37:36Z

Review packet

In one line: On a Gravity Forms form with AJAX turned on, the GoDAM Record field now keeps working after the visitor changes page or a submit fails, so Start Recording opens the recorder again. Fixes #2222. Related to #2159 (same form flow, found while retesting it).

1. Criteria and proof

Acceptance criterion	Proof
On a 5-page AJAX form, after page 1 then Next, Start Recording on each of the 3 Record fields on page 2 opens the recorder and a clip shows its preview (before: it opened nothing in every run)	After video V2 at 0:06 to 0:20; before video V1 at 0:04
Next, then Previous: page 2 shows all 3 recordings again and Start Recording still opens	V2 at 0:25
Removing one recording and recording it again changes only that field	V2 at 0:30; the stored entry holds the new clip for that field and the first clips for the other two
A failed submit on the page that holds the recorders keeps the 3 recordings, Start Recording opens, replacing one clip works, and the form then submits	Scenario `ajax validate`, 10 checks, on Gravity Forms 3.1.2 and on 2.7.7.1 (the older iframe AJAX). Log only, not in the video
Every entry holds exactly one file per Record field, nothing sent twice, no "Number of files (2) exceeds limit (1)"	Entries read back after every run: 6 entries on 3.1.2 and 2 on 2.7.7.1, 1 file in each of the 3 fields
The non-AJAX twin of the same form still works as in 2.3.1	Right pane of V2, plus scenarios `postback plain` and `postback validate`, all checks pass
The recorders of WPForms, Fluent Forms, Everest Forms and SureForms are unaffected	Each page: opens, records 2 s, preview shows, file input holds 1 file, Remove clears both, Start Recording opens again, no JS error

2. Before and after

Left pane: a form with AJAX on (the setup that failed). Right pane: the same form with AJAX off, as a control. Both panes get the same visitor actions. Each step has a check, so a red step is a real failure.

Before (develop, 2.4.0): on the AJAX form, Start Recording opens nothing after Next; the control opens and records

After (this branch): the full flow on both forms, 8 steps, all checked

3. Tests

Added: assets/src/js/godam-recorder/index.test.js, 11 tests. They replace a page's markup the way Gravity Forms does, fire gform_post_render, and assert: the new button opens the dashboard exactly once (also with a different button id, with the event fired three times, and across several page changes); the held recording is shown again; it is not sent again when Gravity Forms holds a copy and is put on the new file input when it does not; removing it after the page change drops Gravity Forms' saved copy; nothing happens while the markup is still on the page; a field that is not on the page yet is picked up when it appears. The Uppy stand-in binds its dashboard trigger once at install, as the real one does.
Changed: none.
Revert check: with develop's index.js put back, 8 of the 11 fail, for example "opens the dashboard from the new button after a page change" with Expected number of calls: 1, Received number of calls: 0. With the fix all 11 pass.

4. Risk flags

No risk flags fired on #2217. Nothing in the diff touched the watched areas.

5. Independent review

A fresh reviewer saw only the task and the diff. It found nothing it could confirm. Two low-confidence points:

Finding	Grade	What I did
Gravity Forms prints its hidden `gform_uploaded_files` input only for multi-file upload fields, so on a form whose only upload fields are Record fields an AJAX page change might throw inside Gravity Forms before `gform_post_render` fires	Invalid	Tested exactly that: a 5-page AJAX form on Gravity Forms 3.1.2 with only Record fields, recorded on page 2, Next to page 3. No JS error; the saved copy was listed and the next page showed. Nothing changed
Two embeds of the same form on one page share container ids, so a detached uploader could pick the other embed's container	By design	The constructor already finds the input by id the same way, so this adds no new limit. Not changed

6. Not verified

Ninja Forms: not installed on the test site, so its recorder was not run. It shares the constructor and its markup follows the same container, input and button ids, which this PR reads exactly as before.
Gravity Forms versions between 2.7.7.1 and 3.1.2 (for example the first 2.9 releases) were not run. 3.1.2 uses true AJAX and 2.7.7.1 the older iframe AJAX; both pass.
A Record field inside a GoDAM video layer on an AJAX form was not run.
Only Chrome (headless, fake camera and screen) was used; Firefox and Safari were not.
Not tested on the live site of the customer behind Gravity Forms: GoDAM Record field fails with "Number of files (2) exceeds limit (1)" on Gravity Forms 2.9.18+ #2159.

7. Scope

The fix is in assets/src/js/godam-recorder/index.js with its new test. languages/godam.pot changes by three source line references (the recorder's lines moved), regenerated with the repo's own build and make-pot, because the POT check requires it. No PHP, no changelog line, no version bump.

What was wrong

When Gravity Forms changes page or fails a submit over AJAX it replaces that page's markup and fires gform_post_render. The recorder kept pointing at the old container, file input and button, and Uppy had bound its dashboard trigger once, to the old button. The old handler also returned unless the form had a validation error, so on a page change nothing was re-bound and Start Recording did nothing, without any error. The server prints the trigger button's id with wp_unique_id(), so it can differ on every render.

What changed

On every gform_post_render, an uploader whose container left the page finds the new container by its id (stable between renders), reads the file input and button from it, adds one click listener to the new button, and shows the recording it already holds again. Nothing changes while the markup is still on the page (first render, a non-AJAX submit, a page the response did not replace). The non-AJAX path and the other form plugins go through the same lookup as before.

Gravity Forms replaces a page's markup on every AJAX page change or failed submit. The recorder kept pointing at the replaced container, file input and button, and Uppy had bound its dashboard trigger once to the old button, so Start Recording opened nothing on the new page. On every gform_post_render, an uploader whose markup left the page now finds the new container by its id, reads the input and button from it, binds the new button once and shows the recording it holds again.

github-actions · 2026-10-19T10:44:59Z

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues	❌ Errors	⚠️ Warnings
15	0	15

⚠️ Warnings (15)

📁 inc/classes/class-video-sitemap.php (1 warning)

📍 Line	🔖 Check	💬 Message
`620`	WordPress.DB.SlowDBQuery.slow_db_query_meta_key	Detected usage of meta_key, possible slow query.

📁 readme.txt (2 warnings)

📍 Line	🔖 Check	💬 Message
`0`	mismatched_plugin_name	Plugin name "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" is different from the name declared in plugin header "GoDAM".
`0`	trademarked_term	The plugin name includes a restricted term. Your chosen plugin name - "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" - contains the restricted term "wordpress" which cannot be used at all in your plugin name.

📁 inc/classes/class-video-sitemap-core-provider.php (1 warning)

📍 Line	🔖 Check	💬 Message
`73`	WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "wp_sitemaps_index_entry".

📁 assets/build/css/main.css (1 warning)

📍 Line	🔖 Check	💬 Message
`0`	EnqueuedStylesScope	This style is being loaded in all contexts.

📁 assets/src/libs/analytics.min.js (5 warnings)

📍 Line	🔖 Check	💬 Message
`0`	EnqueuedScriptsScope	This script is being loaded in all frontend contexts.
`0`	NonBlockingScripts.NoStrategy	This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
`0`	NonBlockingScripts.NoStrategy	This script on http://localhost:8880/2026/10/20/demo-post-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
`0`	NonBlockingScripts.NoStrategy	This script on http://localhost:8880/demo-page-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
`0`	NonBlockingScripts.NoStrategy	This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.

📁 assets/build/js/main.min.js (5 warnings)

📍 Line	🔖 Check	💬 Message
`0`	EnqueuedScriptsScope	This script is being loaded in all frontend contexts.
`0`	NonBlockingScripts.NoStrategy	This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
`0`	NonBlockingScripts.NoStrategy	This script on http://localhost:8880/2026/10/20/demo-post-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
`0`	NonBlockingScripts.NoStrategy	This script on http://localhost:8880/demo-page-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
`0`	NonBlockingScripts.NoStrategy	This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

…ax-page-change # Conflicts: # languages/godam.pot

# Conflicts: # languages/godam.pot

KMchaudhary · 2026-10-20T09:45:29Z

Code review

Verdict: LGTM — solid, well-tested fix with a clean refactor. The root cause (stale container/fileInput/uploadButton references and a one-time Uppy trigger binding after Gravity Forms replaces the page markup) is addressed at the right level: extracting resolveRecorderMarkup() + useMarkup() and re-reading the button id (which the server builds with wp_unique_id(), so it changes every render) from the container each time. Using this.container.isConnected as the "my markup was replaced" signal is a much more robust trigger than the old gform_validation_error / submission-method heuristics, and it correctly no-ops on first render, postbacks, and unrelated forms' renders. The 11 tests with the revert check (8 fail on develop) give good confidence.

A couple of points, one worth a look before merge:

1. Fields that first appear via AJAX get no instance (robustness) — `index.js` bootstrap

Instances are created only once, at DOMContentLoaded, by iterating .uppy-video-upload containers then present. The fix then moves existing instances onto replaced markup (found by the stable containerId). This works for the multi-page case you tested because Gravity Forms renders all pages' HTML up front (hidden), so page-2 containers already exist at load and get an instance.

The gap: a Record field that is absent at load and introduced later via AJAX — a field revealed by GF conditional logic, or a Record field inside a GoDAM video layer loaded on demand (which your "Not verified" list calls out) — never gets an UppyVideoUploader, so gform_post_render has nothing to re-bind and Start Recording does nothing. A global gform_post_render pass that instantiates any uninstantiated .uppy-video-upload container would close this, and would also subsume the "move onto new markup" case. Not a blocker for the verified scenarios, but worth confirming the video-layer path before relying on it.

2. Two embeds of the same form share a container id (acknowledged, not a regression) — `index.js`

handleUppyUIOnAjaxRequest() locates the new container with document.getElementById(this.containerId), which returns the first match. If the same form is embedded twice on one page, after an AJAX page change both instances resolve to the first embed and the second embed's recorder breaks. You've flagged this as by-design/pre-existing (the constructor already resolved by id the same way), so just noting it stays a known limitation.

Minor

setupGravityFormsAjaxHandler() no longer reads formId, so every uploader instance's handler runs on every form's gform_post_render. It's correctly guarded by isConnected, so this is safe — just O(instances) cheap checks per render event. Fine to leave as-is.

Nice work on the test harness that replays gform_post_render the way GF does, and on documenting the exact "not verified" surface.

_{🤖 Automated review via Claude Code (/code-review, high effort).}

subodhr258 · 2026-10-20T10:46:42Z

@KMchaudhary on your comment:

Thanks Kuldip.

Record fields that appear later: partly. In the player, a Gravity Forms layer is rendered into the page at load (inc/templates/godam-player.php:919), and Gravity Forms prints conditional-logic fields hidden, so both get an uploader at DOMContentLoaded. The on-demand gform endpoint is only used by the video editor preview (pages/video-editor/redux/api/gravity-forms.js:32). It can still happen when another plugin loads the form later, for example in a popup, so creating an uploader for any new container on gform_post_render goes on the follow-up list.
Same form embedded twice: agreed, a known limitation from before this PR.

Minor: agreed, isConnected keeps it safe, so it's left as is.

@SInCE

* Stop the admin menu jumping when a GoDAM page loads (#2207) * Fix: stop the admin menu jumping when a GoDAM page loads pages/style.css restores Tailwind's border reset for every element on the page. It is injected by page-css.min.js after the page has painted, and core's a { transition: border .05s } then animates each admin menu link's border from 3px to 0: every item grows from 34px to 40px and the whole menu jumps by about 186px, then snaps back. Keep the reset off #adminmenumain and #wpadminbar. * Fix: open the Media Editor with the admin menu already folded The editor folds the menu from React after the page has painted, so the menu showed at full width and then collapsed. Add the folded body class on the server when the editor opens a file. * Keep the reset off the menu and admin bar containers too; test the editor fold - pages/style.css also excludes #adminmenumain and #wpadminbar themselves, not only their descendants. - MediaEditorMenuFoldTest: the Media Editor with an id gets 'folded'; its file picker, other GoDAM pages, the Media Library and no screen do not. * Regenerate the POT: 12 references into class-pages.php moved down Line numbers only; no strings added or changed. Built like CI: Node 22.14.0, npm ci, npm run build:prod, composer pot. * feat(seo): fix VideoObject schema and add video sitemap (#2186) * feat(seo): fix VideoObject schema and add video sitemap (#1622 v1) Make GoDAM's video schema indexable by Google and add a video sitemap that plugs into Yoast SEO, Rank Math, All in One SEO or the WordPress core sitemap. No new public URLs are created. - Schema contentUrl now uses the HLS (.m3u8) stream, falling back to the original file; the DASH .mpd is never output. Resolved at output time, so pages cached before this change are fixed without a re-save. - Add embedUrl pointing at GoDAM's existing video-embed player page. - Never output an empty description: fall back to a 160-char transcript excerpt (fetched on save only, cached in _godam_seo_transcript_excerpt), then the page excerpt, otherwise omit the property. - Output isFamilyFriendly as a real JSON boolean (string values such as "false" are parsed correctly) and omit an empty uploadDate. - Add Video_Sitemap: /godam-video-sitemap.xml with one <url> per published page and one <video:video> per video, built from the cached video SEO post meta via the shared schema builder so both always agree. - Exclude drafts, private and password-protected posts, pages noindexed in Yoast / Rank Math / AIOSEO, and videos the editor excludes. - List the sitemap in the Yoast, Rank Math and AIOSEO indexes, or via a core sitemap provider when none is active; paginate at 1000 URLs, cache per site with version-based invalidation. - Add GoDAM > Settings > SEO with an "Enable video sitemap" toggle (off by default) and a per-video "Exclude from video sitemap" toggle in Gutenberg, Elementor and WPBakery. - Warn editors in all three editors when a video title looks like a raw file name. - Prefer the HLS URL when prefilling SEO contentUrl in the editors. - Add new filters: godam_video_seo_content_url, godam_video_seo_embed_url, godam_video_seo_description, godam_video_sitemap_enabled, godam_video_sitemap_entries_per_page, godam_video_sitemap_post_types, godam_video_sitemap_exclude_post, godam_video_sitemap_entry. - Add PHPUnit coverage (VideoSeoSchemaTest, VideoSitemapTest) and Jest tests for the filename-title check. * Resolve feedback * Resolve feedbacks and regenrate POT file * Revert the POT file * Resolve Privacy Issue * feat(seo): add key moments to video schema from chapters (#1597) (#2194) Output each GoDAM video chapter as a schema.org Clip in the VideoObject's hasPart, so Google can show "key moments" (jump-to links) for the video in search results. - Add Seo::get_key_moment_clips(): reads the chapters from the attachment's rtgodam_meta at output time, so editing chapters updates the schema without re-saving the page. - Each Clip has name, startOffset, endOffset and a deep link of the form <page>?t=<seconds>#godam-video-<attachment id>, which the GoDAM player already uses to seek on page load. - A clip ends at the chapter's own endTime, else the next chapter's start, else the video duration (clamped to the duration when known). - Skip chapters with no title, an unreadable start, a start at or past the end of the video, or zero length; drop duplicate start times; strip HTML from chapter names. - Parse chapter times as plain seconds, mm:ss or hh:mm:ss(.ms), falling back to originalTime when startTime is missing. - Build clip URLs without add_query_arg(): use & on plain permalinks and drop any existing fragment from the page URL. - Only add hasPart when the video has an attachment and a host page (render-time output on archives/404 has nothing to deep-link to). - Add filters godam_video_seo_key_moments_enabled and godam_video_seo_key_moments. - Move ISO 8601 duration parsing to Seo::iso8601_to_seconds(); Video_Sitemap::iso8601_duration_to_seconds() now delegates to it. - Add VideoSeoKeyMomentsTest (27 tests) and a get_permalink() test stub. * Match WPBakery SEO Settings to Gutenberg Model (#2209) * ci: run the POT check only on PRs into main (#2188) * ci: run the POT check only on the develop → main merge Feature PRs into develop no longer have to regenerate languages/godam.pot. The release PR from develop into main still fails if the committed POT is stale. PRs into main from any other branch skip the job. * ci: run the POT check on every PR into main Patch releases reach main from fix and hotfix branches, not only from develop, so they need the check too. The branches: [main] trigger already keeps it off feature PRs into develop. * Pass only a numeric form ID to the form layer preview (#2223) Cast the layer id to an integer in the preview template and in the Ninja Forms and MetForm callbacks, and add unit tests for it. * Keep the Gravity Forms recorder working after an AJAX page change (#2217) * Keep the Gravity Forms recorder working after an AJAX page change Gravity Forms replaces a page's markup on every AJAX page change or failed submit. The recorder kept pointing at the replaced container, file input and button, and Uppy had bound its dashboard trigger once to the old button, so Start Recording opened nothing on the new page. On every gform_post_render, an uploader whose markup left the page now finds the new container by its id, reads the input and button from it, binds the new button once and shows the recording it holds again. * Regenerate the translation template for the recorder's moved lines * Stop sending the signed-in viewer's email with video analytics (#2213) * Stop sending the signed-in viewer's email with video analytics The page params that GoDAM prints on every front-end page no longer carry the current user's email address (`emailId`), and the analytics request body no longer has an `email` field. The WordPress user id is still sent. Tests: the request-body helper and the page params are both checked for the absence of the email, including a page cached by an older version. * Remove the viewer's email from the analytics data listed in the readme The analytics.godam.io entry under External services no longer lists Email as data sent. * Keep the signed-in viewer's email out of the player's page data The player script's page data (godamData.currentLoggedInUserData) carried the current user's email address, which nothing in the browser reads. It now holds the display name and whether someone is signed in. The comments routes still read the email on the server. * Keep the fixture lines untouched in the JS test The explanation moves into the test, so the fixture lines this branch leaves alone cannot conflict with the sibling change. * List the page's user fields instead of removing one rtgodam_get_current_user_data_for_page() now returns only the display name and the sign-in type, so a field added later to the server-side user data is not printed into the page by accident. * Regenerate the POT for the new line numbers The new helper in custom-functions.php moves five strings further down the file, so their source references change. Nothing else in the file differs from develop. * Clean up video share popup: remove GoDAM Central/Embed links, use Page link, show share button for all videos (#2211) * Clean up video share popup links and share button gating - Remove the redundant GoDAM Central and Embed copy fields from the share modal footer, keeping only the Page Link field. - Point the social share links at the WordPress page link instead of the GoDAM Central URL, which is private by default and shows a login prompt. - Show the share button for all videos when sharing is enabled in the block settings, instead of only transcoded videos. Closes #2210 * Address review: keep share anchor and gate button on an ID - Encode the share link with encodeURIComponent so the #godam-video-{id} anchor and any query param travel with the social share URL instead of splitting off (encodeURI left #, ? and & intact). - Hide the share button for players with neither a WordPress attachment ID nor a transcoding job ID ("Insert from URL" embeds), since their share link could not target the video. - Remove stale README references to the removed GoDAM Central/Embed links and correct the ID described for share links. --------- Co-authored-by: KMchaudhary <kuldipkumar.chaudhary@rtcamp.com> * Save converted MP3 audio as audio/mpeg, and fix files already saved as audio/mp3 (#2208) * Fix: store transcoded MP3 audio as audio/mpeg, not audio/mp3 WordPress registers MP3 as audio/mpeg. Attachments saved as audio/mp3 were left out of REST media_type=audio, and REST ignored a mime_type=audio/mp3 filter. New conversions are saved as audio/mpeg, and a one-time migration (2.4.1 batch) fixes the ones saved before. * Test the saved type, satisfy the hook-integrity check, retry a failed SELECT - TranscodedAudioMimeTypeTest calls add_transcoded_files() and checks that converted audio is saved as audio/mpeg (video stays video/mp4). With the old audio/mp3 it fails. - add_transcoded_files() starts $transcoded_files as array(), not false; PHP 8.1+ reported every conversion as a deprecated false-to-array use. - The migration's two direct queries carry godam-coverage-ignore: the runner already runs it once per site. - A failed SELECT now returns false so the runner retries, instead of marking the site done with nothing changed. - The runner test checks batch order instead of which batch is last. * Run the MP3 type migration in the 2.5.0 batch 2.4.1 ships without this change but still stores 2.4.1 as each site's migration version, and the runner skips batches at or below the stored version. Keyed 2.4.1, the migration would never run on sites that update through 2.4.1; keyed 2.5.0 it runs for both 2.4.0 and 2.4.1 sites. * Release prep v2.5.0: version bump, changelog and POT refresh (#2231) - Version 2.5.0 in godam.php, readme.txt, README.md, package.json and package-lock.json. - v2.5.0 changelog in readme.txt and CHANGELOG.md; v2.3.2 removed from readme.txt to keep the last three. - Every @SInCE n.e.x.t replaced with 2.5.0 (51 tags in 6 files). - languages/godam.pot regenerated from a production build. * Fix the two new Plugin Check warnings in the Video SEO sitemap code (#2232) - class-video-sitemap.php: the phpcs:ignore named slow_query_meta_key, which is not a sniff, so it ignored nothing. Use slow_db_query_meta_key. - class-video-sitemap-core-provider.php: ignore NonPrefixedHooknameFound on WordPress core's own wp_sitemaps_index_entry filter. * Keep page-builder shortcode text out of the video sitemap description (#2235) * Keep page-builder shortcode text out of the video sitemap description The sitemap is served at parse_request priority 1, before WPBakery and Divi register their shortcodes, so core's strip_shortcodes() left tags such as [vc_row] in the fallback description taken from the page text. Add the tag names found in the text to strip_shortcodes()'s own list so unregistered shortcodes are removed the same way registered ones are, which gives the same description in the sitemap and on the front end. The strip_shortcodes() test stub removed every [tag], which hid the bug. It now follows core: only registered shortcodes are removed. * Only strip builder-style unregistered shortcode names from the fallback description Review of the first version found that it also removed ordinary bracketed text ([sic], [1], [b]bold[/b]) from the front-end description, that one very long bracketed word made core's pattern too large and the description empty, that a tag another filter had taken off the strip list was re-added, and that the filter stayed registered if stripping threw. Only names that look like a builder tag are added now (a letter first, an underscore or hyphen in the name, 64 characters at most), tags that are registered are left to core, and the filter is removed in a finally block. New tests pin the cap, the length limit, the filter removal and the ordinary bracketed text. * Set the 2.5.0 changelog date to October 22, 2026 (#2236) 2.5.0 releases on 22 Oct (release ticket rtCamp/godam-plugin-wp#60), but readme.txt and CHANGELOG.md dated it October 21. --------- Co-authored-by: Kuldip Chaudhary <64731232+KMchaudhary@users.noreply.github.com> Co-authored-by: Rudrakshi Gupta <109859631+rudrakshi-gupta@users.noreply.github.com> Co-authored-by: Vishal Kumar <vishnshiv3@gmail.com> Co-authored-by: KMchaudhary <kuldipkumar.chaudhary@rtcamp.com>

subodhr258 mentioned this pull request Oct 19, 2026

Gravity Forms: the Record field stops working after an AJAX page change #2222

Closed

subodhr258 requested review from KMchaudhary and elifvish October 19, 2026 17:59

subodhr258 added 3 commits October 19, 2026 23:38

Regenerate the translation template for the recorder's moved lines

34868c6

Merge remote-tracking branch 'origin/develop' into fix/gf-recorder-aj…

4fe7eb5

…ax-page-change # Conflicts: # languages/godam.pot

Merge branch 'develop' into fix/gf-recorder-ajax-page-change

0eb256c

# Conflicts: # languages/godam.pot

KMchaudhary approved these changes Oct 20, 2026

View reviewed changes

subodhr258 merged commit fdd53f8 into develop Oct 20, 2026
4 checks passed

subodhr258 deleted the fix/gf-recorder-ajax-page-change branch October 20, 2026 10:29

This was referenced Oct 20, 2026

Release prep v2.5.0: version bump, changelog and POT refresh #2231

Merged

Develop to main sync for 2.5.0 release #2238

Merged

Navigation Menu

Repository navigation

Keep the Gravity Forms recorder working after an AJAX page change - #2217

Keep the Gravity Forms recorder working after an AJAX page change#2217
subodhr258 merged 4 commits into
developfrom
fix/gf-recorder-ajax-page-change

subodhr258 commented Oct 19, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 19, 2026 •

edited

Loading

Uh oh!

KMchaudhary commented Oct 20, 2026

Uh oh!

Uh oh!

subodhr258 commented Oct 20, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

subodhr258 commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review packet

1. Criteria and proof

2. Before and after

3. Tests

4. Risk flags

5. Independent review

6. Not verified

7. Scope

What was wrong

What changed

Uh oh!

github-actions Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔍 WordPress Plugin Check Report

📊 Report

⚠️ Warnings (15)

Uh oh!

KMchaudhary commented Oct 20, 2026

Code review

1. Fields that first appear via AJAX get no instance (robustness) — index.js bootstrap

2. Two embeds of the same form share a container id (acknowledged, not a regression) — index.js

Minor

Uh oh!

Uh oh!

subodhr258 commented Oct 20, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

subodhr258 commented Oct 19, 2026 •

edited

Loading

github-actions Bot commented Oct 19, 2026 •

edited

Loading

1. Fields that first appear via AJAX get no instance (robustness) — `index.js` bootstrap

2. Two embeds of the same form share a container id (acknowledged, not a regression) — `index.js`