[rudrakshi-gupta]

Summary

GoDAM already adds VideoObject JSON-LD to every page with a GoDAM video, but the schema had problems:

• It pointed Google at the DASH .mpd manifest, which Google can't index.
• It had no embedUrl.
• It output empty descriptions.
• isFamilyFriendly could be stored as a string.

There was also no video sitemap.

This PR delivers v1 of the Video SEO epic:

• It fixes the schema.
• It adds a video sitemap that plugs into Yoast SEO, Rank Math, All in One SEO, or the WordPress core sitemap.
• It adds a site-wide on/off switch (off by default) and a per-video "Exclude from video sitemap" toggle.
• It warns editors when a video title looks like a raw filename.

No new public URLs are created. The sitemap lists only pages that already exist, which avoids the thin-page problem from #616 / #1798 / #1836.

Part of #1622 (v1). The key moments, transcript-in-schema and graph-merge items are left for the follow-up release; see Out of scope.

Before / after

	Before	After
contentUrl	DASH .mpd (rtgodam_transcoded_url), which Google can't index	HLS .m3u8, falling back to the original file. Never .mpd
embedUrl	Missing	GoDAM player URL (?godam_page=video-embed&id=<id>)
description	Output as "" when empty	Own description → transcript excerpt (160 chars) → page excerpt → omitted
isFamilyFriendly	(bool) cast, so "false" became true	Real JSON boolean; string values parsed correctly
uploadDate	Output as "" when empty	Omitted when empty
Filename-style titles	No warning	Editor warning in Gutenberg, Elementor and WPBakery
Video sitemap	None	/godam-video-sitemap.xml, listed in the active SEO plugin's index or in /wp-sitemap.xml

What's included

1. Schema fixes (inc/classes/class-seo.php)

• contentUrl
  • New get_attachment_content_url() returns the HLS URL (rtgodam_get_hls_transcoded_url_from_attachment()), or the original file URL when no HLS URL exists. A DASH URL is never returned (is_dash_url()).
  • It's resolved at output time from attachment_id, so block pages cached before this change, whose post meta still holds the .mpd, are corrected without a re-save.
  • Older Elementor and WPBakery caches have no attachment_id, so they can't be resolved at output time. The first time such a page is output, it's queued for a one-time background re-save:
    • A post meta flag (_godam_seo_legacy_resave) makes sure each page is queued only once.
    • Page IDs are collected for the request and written to one queue option (godam_video_seo_resave_queue) at shutdown, with a single WP-Cron event (godam_video_seo_resave_batch).
    • Each cron run re-saves 10 pages and schedules the next run while pages remain, so a site with hundreds of old pages doesn't rewrite the cron option or re-save everything in one request.
  • Videos that finish HLS transcoding after the page was saved switch to HLS automatically.
  • For entries without an attachment, a stored .mpd is dropped rather than output.
• embedUrl: new get_embed_url() builds the URL of GoDAM's existing video-embed page.
• Description fallbacks (resolve_schema_description()):
  1. The entry's own description, with HTML stripped.
  2. The transcript excerpt (get_transcript_excerpt()).
     • It parses WebVTT and SRT (transcript_to_text()) and trims to 160 characters at a word boundary (trim_to_length()).
     • It's fetched only on save, then cached on the attachment in _godam_seo_transcript_excerpt, keyed by transcript path, so a new transcript is picked up.
     • Page renders only ever read the cache.
     • Files in uploads are read from disk; others go through wp_safe_remote_get() with a 3s timeout.
     • A failed fetch is cached too and retried after an hour, so a dead transcript URL doesn't slow down every save. Deleted transcripts are ignored.
     • Transcript paths with a NUL byte or outside uploads are rejected.
  3. The page excerpt, or the start of the page text with block comments and shortcodes stripped, without rendering.
  4. Otherwise the property is left out.
• isFamilyFriendly: new Seo::to_bool() handles "True", "false", "0", "yes", "", etc.
• Empty uploadDate is left out.
• build_video_object_schema() is now public, so the sitemap reuses it. The sitemap and the schema always agree.
• get_seo_from_attachment() gains an $allow_remote parameter, so the render-time collector never fetches a transcript.
• Elementor and WPBakery entries now carry attachment_id, including override entries, so the same resolution applies to them.
• The per-video exclude flag is carried into the cached entries as excludeFromSitemap.

2. Video sitemap (new inc/classes/class-video-sitemap.php, class-video-sitemap-core-provider.php)

• URL: /godam-video-sitemap.xml, with pages 2+ at /godam-video-sitemap2.xml and so on. Sites on plain permalinks use /?godam_video_sitemap=N.

• Content:

  • One <url> per published page that contains GoDAM videos.
  • One <video:video> per video, with thumbnail_loc, title, description, content_loc (HLS), player_loc, duration (seconds), publication_date, and family_friendly (no only when false).
  • Videos missing a required field are skipped. A missing thumbnail falls back to the featured image; a missing description falls back to the title.
  • The same video placed twice on a page is listed once.

• Turned on or off by the setting, or in code with godam_video_sitemap_enabled (read at after_setup_theme, so a theme can use it).

• Data source: the existing video SEO post meta (godam_video_seo_schema), passed through Seo::build_video_object_schema().

• Exclusions:

  • Drafts, pending, scheduled and private posts (post_status = publish).
  • Password-protected posts.
  • Pages marked noindex by Yoast (per page and the post-type default), Rank Math (Helper::is_post_indexable()) or AIOSEO (per page and the post-type default).
  • Videos with "Exclude from video sitemap" on.

• Serving:

  • GoDAM serves the XML itself on parse_request at priority 1, so Yoast, Rank Math, AIOSEO and core don't intercept the *-sitemap.xml URL.
  • It sends X-Robots-Tag: noindex, follow.
  • A page past the last one returns 404.
  • A Sitemap: line for it is added to /robots.txt (skipped when the site discourages search engines).

• Registration:

  Active SEO plugin	Hook
  Yoast SEO	wpseo_sitemap_index_links
  Rank Math	rank_math/sitemap/index
  All in One SEO	aioseo_sitemap_indexes
  None of the above	Video_Sitemap_Core_Provider registered on wp_sitemaps_init (listed in /wp-sitemap.xml)

  Why GoDAM serves the XML itself: WordPress core's sitemap renderer only supports loc, lastmod, changefreq and priority, so it can't output <video:*> tags. The three SEO plugins also each handle custom sitemap content differently. Serving one XML document and listing its URL in whichever index is active gives identical output in every setup. The core provider overrides get_sitemap_url() to point at GoDAM's sitemap.

• Scale and caching:

  • Pages of 1,000 URLs (filterable).
  • Page XML, total count and lastmod are cached in transients, keyed by a version option (godam_video_sitemap_cache_version).
  • The version is bumped when video SEO is saved or cleared, on publish/unpublish of a page with videos, on deletion of such a page or a used video, on edit_attachment, and on settings changes.

• Multisite: transients and queries are per site, so each sub-site has its own sitemap at its own URL.

3. Settings

• GoDAM → Settings → SEO (new tab, pages/godam/components/tabs/SeoSettings/SeoSettings.jsx):
  • "Enable video sitemap" toggle, off by default, stored at rtgodam-settings[seo][enable_video_sitemap] with defaults and sanitization in class-settings.php.
  • When it's on, the tab shows the sitemap URL and which index lists it. The data is localized as godamVideoSitemap from class-pages.php.
• Per-video "Exclude from video sitemap" toggle:
  • Gutenberg: new block attribute excludeFromVideoSitemap, set from the Video SEO modal. It works whether SEO override is on or off.
  • Elementor: new seo_exclude_from_sitemap switcher in the SEO Settings popover.
  • WPBakery: new seo_exclude_from_sitemap param in the SEO Settings tab.
  • Excluding a video removes it from the sitemap only. Its JSON-LD still outputs.

4. Filename-style title warning

• New isFilenameLikeTitle() and getFileNameFromUrl() in assets/src/blocks/godam-player/utils/index.js.
• A title with no spaces is flagged when it has two or more hyphens/underscores (product-demo_v2), is a camera or phone name (IMG_2041, PXL_20240115), or ends in a video extension (clip.mp4). One separator isn't enough (Spider-Man, Paris-2024).
• A title that matches the video's file name (with or without extension) is flagged only when it also looks machine-made: no spaces, or a date or time in it (Screen Recording 2024-01-15 at 10.30.45). WordPress builds titles from the uploaded file name, so a well-named upload such as Product Demo.mp4 → "Product Demo" isn't flagged.
• Gutenberg: a warning notice under Headline in the Video SEO modal. The wording depends on override state: "edit the title in the Media Library" when override is off, "use a descriptive title" when it's on.
• Elementor: the Headline help text turns into an amber warning, and updates as the headline, override or video changes.
• WPBakery: a warning box under "Override SEO". It checks the Media Library title when override is off and the Headline field when it's on.

5. Editor contentUrl defaults

• In the Gutenberg block (edit.js, VideoSEOModal.js) and the Elementor widget script, the prefilled SEO contentUrl now prefers rtgodam_hls_transcoded_url / hls_url over the DASH URL.
• The help text no longer suggests MPD.
• Player sources are unchanged.

New hooks

Hook	Type	Purpose
godam_video_seo_content_url	filter	Change the resolved contentUrl / content_loc for an attachment
godam_video_seo_embed_url	filter	Change or remove embedUrl / player_loc (return '' to omit)
godam_video_seo_description	filter	Change the resolved description
godam_video_sitemap_enabled	filter	Force the sitemap on or off in code
godam_video_sitemap_entries_per_page	filter	URLs per sitemap page (default 1000, max 50000)
godam_video_sitemap_post_types	filter	Post types that can appear (default: public types minus attachment)
godam_video_sitemap_exclude_post	filter	Exclude a page (receives the noindex result)
godam_video_sitemap_entry	filter	Modify or drop a page entry

Data changes

• New attachment meta _godam_seo_transcript_excerpt: { path, text } cache of the transcript excerpt, or { path, failed_at } after a failed fetch.
• New post meta _godam_seo_legacy_resave: set once a page with an older Elementor/WPBakery cache is queued for its re-save.
• New option godam_video_seo_resave_queue: page IDs waiting for that re-save, not autoloaded; empty once the queue is done.
• New WP-Cron event godam_video_seo_resave_batch: single events, only while the queue has pages.
• New option godam_video_sitemap_cache_version: not autoloaded.
• New setting rtgodam-settings[seo][enable_video_sitemap]: default false.
• New block attribute excludeFromVideoSitemap: default false, so existing blocks need no migration.
• No database schema changes, no rewrite-rule changes, no new public URLs.

Out of scope (follow-up release)

• Key moments from chapters as Clip in hasPart (Add key moments into video SEO automatically from video chapters data #1597).
• Transcript in the schema.
• Listing videos that live only in templates, template parts or synced patterns in the sitemap. Their schema gets every fix here through the shared builder; they just aren't in post meta, so the sitemap can't list them yet.
• Merging GoDAM's VideoObject into the Yoast / Rank Math schema graph.
• Turning the sitemap on by default.

Testing

Automated

• composer phpunit: all tests pass, including the new suites:
  • tests/php/VideoSeoSchemaTest.php (49): HLS contentUrl and fallbacks, .mpd never output, embedUrl, the description fallback chain and omission, transcript fetch/cache/parse (VTT and SRT), isFamilyFriendly booleans, empty uploadDate.
  • tests/php/VideoSitemapTest.php (39): well-formed XML and namespaces, escaping, required fields and fallbacks, sitemap/schema parity, de-duplication, every exclusion rule (status, password, Yoast/Rank Math noindex, per-video exclude, filter), URL parsing, pagination URL, off by default, duration conversion.
  • New stubs in tests/stubs/video-seo-functions.php.
• npx wp-scripts test-unit-js assets/src/blocks/godam-player/utils/index.test.js: 35 tests pass (filename-title rule).
• vendor/bin/phpcs on the changed PHP files: clean.
• npm run lint:godam-hooks: balance OK, 0 uncovered call sites. New host-post reads are annotated with godam-coverage-ignore.
• wp-scripts lint-js on the changed JS: no new errors.

Manual (all passed locally)

1. Schema: on pages using the Gutenberg block, Elementor widget and WPBakery element, with SEO override on and off:
   • contentUrl is .m3u8, or .mp4 for untranscoded videos;
   • embedUrl loads the player;
   • description follows the fallback chain and is never "";
   • isFamilyFriendly is a JSON boolean;
   • Google Rich Results Test (Code tab) detects a Video with no errors.
2. Old pages: a block page saved before this branch shows .m3u8 without a re-save. Elementor and WPBakery pages show it after one WP-Cron run.
3. Template / synced pattern video: the footer schema has the same fixes.
4. Filename warning:
   • appears for product-demo_v2 in all three editors;
   • clears with a descriptive title;
   • doesn't appear for How to set up GoDAM or Product demo - part 2.
5. Settings:
   • the new SEO tab;
   • the sitemap is off by default;
   • /godam-video-sitemap.xml 404s while off;
   • the per-video toggle exists in all three editors.
6. Sitemap:
   • correct entries and fields;
   • draft, private, password-protected and noindexed pages are excluded;
   • excluded videos are dropped while their schema remains;
   • listed in the Yoast, Rank Math and AIOSEO indexes and in /wp-sitemap.xml with no SEO plugin;
   • pagination via godam_video_sitemap_entries_per_page;
   • updates after a media title edit.
7. Regression:
   • playback unchanged;
   • other settings tabs save;
   • the GoDAM for Woo Shoppable Video schema still outputs.

Screenshots

Note for docs

Google shows a video as a video result only when the video is the main content of its page. The sitemap helps Google find videos; it doesn't make every page with a video appear as a video result.

[github-actions]

🔍 WordPress Plugin Check Report

⚠️ Status: Passed with warnings

📊 Report

🎯 Total Issues	❌ Errors	⚠️ Warnings
15	0	15

---

⚠️ Warnings (15)

📁 inc/classes/class-video-sitemap.php (1 warning)

📍 Line	🔖 Check	💬 Message
620	WordPress.DB.SlowDBQuery.slow_db_query_meta_key	Detected usage of meta_key, possible slow query.

📁 readme.txt (2 warnings)

📍 Line	🔖 Check	💬 Message
0	mismatched_plugin_name	Plugin name "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" is different from the name declared in plugin header "GoDAM".
0	trademarked_term	The plugin name includes a restricted term. Your chosen plugin name - "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" - contains the restricted term "wordpress" which cannot be used at all in your plugin name.

📁 inc/classes/class-video-sitemap-core-provider.php (1 warning)

📍 Line	🔖 Check	💬 Message
73	WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound	Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "wp_sitemaps_index_entry".

📁 assets/build/css/main.css (1 warning)

📍 Line	🔖 Check	💬 Message
0	EnqueuedStylesScope	This style is being loaded in all contexts.

📁 assets/src/libs/analytics.min.js (5 warnings)

📍 Line	🔖 Check	💬 Message
0	EnqueuedScriptsScope	This script is being loaded in all frontend contexts.
0	NonBlockingScripts.NoStrategy	This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0	NonBlockingScripts.NoStrategy	This script on http://localhost:8880/2026/10/20/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0	NonBlockingScripts.NoStrategy	This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.
0	NonBlockingScripts.NoStrategy	This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead.

📁 assets/build/js/main.min.js (5 warnings)

📍 Line	🔖 Check	💬 Message
0	EnqueuedScriptsScope	This script is being loaded in all frontend contexts.
0	NonBlockingScripts.NoStrategy	This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0	NonBlockingScripts.NoStrategy	This script on http://localhost:8880/2026/10/20/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0	NonBlockingScripts.NoStrategy	This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.
0	NonBlockingScripts.NoStrategy	This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead.

---

🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check

[Copilot]

🟡 Changes recommended

Path containment, transcript parsing, sitemap cache invalidation, and title-length issues remain unresolved.

4 open findings

• Path prefix check allows transcript reads outside uploads · New
• WebVTT parser mishandles cue IDs and numeric dialogue · New
• Sitemap cache is not invalidated after HLS URL updates · New
• Video sitemap titles exceed Google’s 100-character limit · New

What changed in this PR

Adds corrected VideoObject metadata, a configurable video sitemap, and editor-side SEO guidance.

Changes:

• Resolves indexable video URLs, descriptions, embeds, and boolean schema values.
• Integrates a cached video sitemap with SEO plugins and WordPress core.
• Adds sitemap controls, filename warnings, and automated tests.

File	Description
tests/​stubs/​video-seo-functions.php	Adds WordPress/SEO test stubs.
tests/​php/​VideoSitemapTest.php	Tests sitemap behavior.
tests/​php/​VideoSeoSchemaTest.php	Tests schema and transcripts.
pages/​godam/​redux/​slice/​media-settings.js	Adds SEO settings state.
pages/​godam/​components/​tabs/​SeoSettings/​SeoSettings.jsx	Adds SEO settings UI.
pages/​godam/​App.js	Registers the SEO tab.
inc/​classes/​wpbakery-elements/​class-wpb-godam-video.php	Adds sitemap exclusion control.
inc/​classes/​rest-api/​class-settings.php	Sanitizes sitemap settings.
inc/​classes/​elementor-widgets/​class-godam-video.php	Adds Elementor SEO controls.
inc/​classes/​class-video-sitemap.php	Implements sitemap generation and integrations.
inc/​classes/​class-video-sitemap-core-provider.php	Adds the core sitemap provider.
inc/​classes/​class-seo.php	Corrects schema and transcript fallbacks.
inc/​classes/​class-plugin.php	Initializes the sitemap service.
inc/​classes/​class-pages.php	Localizes sitemap details.
assets/​src/​js/​wpbakery/​wpbakery-video-selector-param.js	Adds WPBakery title warnings.
assets/​src/​js/​elementor/​widgets/​godam-video.js	Adds Elementor title warnings.
assets/​src/​blocks/​godam-player/​utils/​index.test.js	Tests filename detection.
assets/​src/​blocks/​godam-player/​utils/​index.js	Adds filename detection helpers.
assets/​src/​blocks/​godam-player/​edit.js	Prefers HLS SEO URLs.
assets/​src/​blocks/​godam-player/​components/​VideoSEOModal.js	Adds warnings and exclusion control.
assets/​src/​blocks/​godam-player/​components/​video-seo-modal.scss	Styles filename warnings.
assets/​src/​blocks/​godam-player/​block.json	Adds the exclusion attribute.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[KMchaudhary]

Code review — VideoObject schema + video sitemap

Overall this is a solid, well-tested change (the tests/php coverage and the schema↔sitemap agreement test are especially nice). A few things worth a look before merge, roughly in priority order:

1. isFilenameLikeTitle flags legitimate hyphenated/underscored titles — assets/src/blocks/godam-player/utils/index.js:163

if ( ! hasSpaces && /[-_]/.test( trimmed ) ) {
    return true;
}

Any single word with a hyphen or underscore and no space is treated as a file name. Real titles trip this: "Spider-Man", "COVID-19", "e-commerce", "Add-ons", "Q3_review". All three authoring UIs (block Notice, Elementor help text, WPBakery warning) will then wrongly tell the user their title "looks like a file name." Consider requiring a stronger signal (e.g. a known media extension, or the title actually matching the file name) rather than "any hyphen/underscore in a single word."

2. Sitemap cache is fully invalidated on unrelated edits — inc/classes/class-video-sitemap.php:85

add_action( 'edit_attachment', array( $this, 'invalidate_cache' ) );
...
add_action( 'update_option_rtgodam-settings', array( $this, 'invalidate_cache' ) );

invalidate_cache() bumps a global version, discarding every cached sitemap page. It fires on any attachment edit (e.g. changing alt text on an unrelated image) and on any GoDAM settings save (not just the SEO toggle). Rebuilding is expensive — a full WP_Query over all public pages plus a per-video build_video_object_schema() for each page. On sites that touch media regularly the transient is effectively never warm. Worth narrowing: only invalidate on attachment edits when the attachment is a video / is referenced by a cached page, and only on the settings save when the SEO/sitemap portion actually changed.

3. Index can advertise sitemap pages that render empty — inc/classes/class-video-sitemap.php:604

get_total_count() / get_max_pages() count posts that merely have VIDEO_SEO_SCHEMA_META_KEY, but get_url_entries() further drops noindexed pages, per-video-excluded videos, and videos that fail is_valid_video(). So get_index_items() and the core/Yoast/Rank Math/AIOSEO index entries can list pages (and inflated counts) whose <urlset> comes back empty — which Search Console reports as empty sitemaps. (No videos are lost across page boundaries, so this is cosmetic/SEO-wart rather than data loss.)

4. Stale-response race in the WPBakery filename warning — assets/src/js/wpbakery/wpbakery-video-selector-param.js:264

updateFilenameTitleWarning() resolves fetchAttachmentData() and then mutates the warning node with no request sequencing or abort. Switching videos (or editing the headline/override) twice quickly can let the earlier request resolve last and show/hide the warning based on the stale attachment. A request token or abort-on-new-call would fix it.

5. transcript_to_text can drop valid spoken lines — inc/classes/class-seo.php:648

if ( preg_match( '/^(WEBVTT|NOTE|STYLE|REGION)\b/', $lines[0] ) ) { continue; }

A whole cue block is dropped when its first text line starts with NOTE/REGION/etc., and separately any cue line that is purely digits is skipped. Legitimate caption text like "Note this down…", "Region four results", or a standalone "2024" is lost from the fallback description excerpt. Minor (fallback path only), but a tighter match (only treat these as headers outside cue bodies) would avoid it.

---

🤖 Generated with Claude Code

[subodhr258]

Reviewed at d7368b1: read the PHP and JS, ran PHPUnit (408 pass), and reproduced the issues below with small scripts against the PR's code. Not run in a browser or against live Yoast, Rank Math or AIOSEO installs.

Requesting changes for one security issue (inline on class-seo.php line 1090): the page-text description fallback lets an Author put </script> into the JSON-LD and run their own script on the page. The rest are smaller.

Earlier feedback

Earlier comment	At d7368b1
Filename warning flags "Spider-Man", "COVID-19"	Fixed. One new false positive and one common miss, inline
Cache cleared on any attachment edit or any settings save	Fixed for those two. Still cleared on almost every post save, inline
Index lists pages that come out empty	Fixed. The index now builds every page to count it, inline
WPBakery filename warning race	Fixed (ran the file with a slow then a fast request; the late one is ignored)
transcript_to_text() drops NOTE and numeric lines	Fixed
Copilot: uploads path containment	Fixed. A null-byte fatal sits next to it, inline
Copilot: WebVTT cue IDs	Fixed
Copilot: sitemap stale after HLS finishes	Fixed (post meta hooks)
Copilot: <video:title> over 100 characters	Fixed

The Copilot threads have no replies yet. A "fixed in d7368b1" on each would help whoever looks next.

Claims

Claim	How checked	Result
contentUrl is HLS, never .mpd, fixed without a re-save	Code	True for block pages. Old Elementor and WPBakery pages lose contentUrl and get no embedUrl until re-saved, inline
Description is never "": own, then transcript, then page text	Code + script	True. The page-text fallback has the security issue and leaks password-protected text, inline
Sitemap XML is valid for Google	Generated output checked with xmllint against Google's sitemap-video.xsd	Valid
GoDAM serves the XML before Yoast, Rank Math, AIOSEO and core	Read their source	True: parse_request at priority 1 runs first
Index hooks for Yoast, Rank Math, AIOSEO and core	Read their source	Hook names and return shapes are right
Off by default, 404 while off, the setting needs manage_options	Code	True
godam_video_sitemap_enabled forces it on or off in code	Code	Only from plugins loaded before GoDAM, inline
Listed in /wp-sitemap.xml when no supported SEO plugin is active	Code + core	Not when core sitemaps are off, inline
PHP 7.4	Grep for PHP 8-only syntax; min WP is 6.5, so str_* are polyfilled	Clean

CI: "Check the committed POT matches a fresh build" fails because the new strings aren't in languages/godam.pot. Run npm run build:prod && composer pot and commit the result.

godam-for-woo: it calls only Seo::get_instance(), get_seo_from_attachment() and the constants, and those signatures are unchanged, so nothing breaks. One thing to know: Woo runs save_seo_data_as_postmeta() right away on woocommerce_product_set_stock_status (a sale can trigger it), and the save path now fetches transcripts. Failed fetches aren't cached, so a dead transcript URL adds up to 3 s per video on every stock status change. Caching a failure for an hour would stop that.

Not tested: a real browser or block editor, live SEO plugin installs, multisite, Search Console.

[subodhr258]

Re-reviewed at 4aab4f3: read every change since d7368b1, ran PHPUnit (418 pass), ran the title check on sample titles, and test-merged the branch into today's develop. Not run in a browser.

The security issue is fixed. Both JSON-LD outputs now escape <, > and &, and the page text and transcript are stripped again after decoding. The new test covers the </script> case. My change request was for that issue; what's left below is smaller.

Earlier comments

Comment	At 4aab4f3
An Author can close the JSON-LD tag (security)	Fixed
Password-protected page text goes into the schema	Fixed, with a test
Old Elementor and WPBakery pages lose contentUrl and embedUrl	Fixed: those pages are re-saved once in the background. One scale note inline
%00 in a transcript URL breaks the save on PHP 8	Fixed
Sitemap cache cleared on almost every save	Fixed: only when the post had video SEO before
godam_video_sitemap_enabled ignored from a theme	Fixed: decided at after_setup_theme, with a test
Cold build runs per-post queries	Fixed: caches primed in one go
Title check flags "Paris-2024", misses screen-recording titles	Both fixed, but the new comparison flags clean titles too, inline
Settings text wrong when core sitemaps are off	Fixed, plus a Sitemap: line in robots.txt
vc.reload never fires	Fixed (removed)
Woo stock changes wait on a dead transcript URL	Fixed: a failed fetch is remembered for an hour

Still needed before merge: the translation file (POT). "Check the committed POT matches a fresh build" still fails. The last commit put back develop's POT from 16 Oct, so none of this PR's new strings are in it, and develop has changed the POT again since (#2207, the admin menu fix). That makes the POT the one file GitHub shows as conflicting. This order clears both:

1. Merge develop into this branch.
2. Run npm run build:prod && composer pot from a folder named godam. The POT header takes the plugin slug from the folder name, so running it in a worktree with another name fails the check.
3. Commit the result.

@since: the new code now says @since 2.4.1 in about 30 places (it said 2.4.0 before). PRs to develop use @since n.e.x.t, which the release step replaces with the version it actually ships in.

PR description: a few lines no longer match the code: "Failed fetches aren't cached" (now cached for an hour), "corrected without a re-save" (true for blocks; Elementor and WPBakery pages get a background re-save), the filename rule ("flagged when it has hyphens or underscores and no spaces"), and the new robots.txt line isn't mentioned.

Not tested: a browser, live SEO plugins, WP-Cron running the re-save on a real site.

[subodhr258]

One more, found while re-reviewing #2194: on category, tag and author archives the description fallback reads an unrelated post, private ones included (inline on line 1197). It is a privacy issue, so my change request stays open until it is fixed. Everything else is in the review above.

[subodhr258]

Approving at 854cb2d. Everything from my reviews is fixed: archive pages no longer read another post (is_singular() plus is_post_publicly_viewable()), the title check leaves clean titles alone, old pages are re-saved in batches, and @since is n.e.x.t. PHPUnit (542) and the JS tests pass.

The red POT check isn't needed for merge. The POT is regenerated at the develop to main sync, so please ignore my earlier note about it.