Skip to content

upd internal toJSON to avoid jsonlite message about keep_vec_names #4290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

upd internal toJSON to avoid jsonlite message about keep_vec_names #4290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

* The return value of `actionButton()`/`actionLink()` changed slightly: `label` and `icon` are wrapped in an additional HTML container element. This allows for: 1. `updateActionButton()`/`updateActionLink()` to distinguish between the `label` and `icon` when making updates and 2. spacing between `label` and `icon` to be more easily customized via CSS.

* The internal (not `jsonlite::`) implementation of `toJSON` now converts named vectors to named lists in order to avoid jsonlite's message when `keep_vec_names=TRUE`.

# shiny 1.11.1

This is a patch release primarily for addressing the bugs introduced in v1.11.0.
Expand Down
8 changes: 7 additions & 1 deletion R/shiny.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,13 @@ toJSON <- function(x, ..., dataframe = "columns", null = "null", na = "null",
# https://github.com/jeroen/jsonlite/commit/728efa9
digits = getOption("shiny.json.digits", I(16)), use_signif = is(digits, "AsIs"),
force = TRUE, POSIXt = "ISO8601", UTC = TRUE,
rownames = FALSE, keep_vec_names = TRUE, strict_atomic = TRUE) {
rownames = FALSE, keep_vec_names = TRUE, strict_atomic = TRUE, fix_vec_names = TRUE) {

# jsonlite complains about named _vectors_, so we'll force all
# named-vectors to be named-lists
if (fix_vec_names) {
x <- lapply(x, function(L) if (is.null(names(L))) L else as.list(L))
}

if (strict_atomic) {
x <- I(x)
Expand Down