feat(otel): Add bindOtel() support
#4269
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces bindOtel() and withOtelShiny() to enable OpenTelemetry tracing for reactive objects and observers. Adds options shiny.otel.bindall and shiny.otel.graphlocked for automatic binding and graph locking. Updates reactiveVal, reactiveValues, reactive, and observe to support automatic OpenTelemetry binding. Documentation and NAMESPACE updated accordingly.
Included r-lib/otelsdk in the Remotes field to enable installation from GitHub. This supports dependencies required for development or testing.
schloerke
changed the title
bindOtel()bindOtel() support
|
Current test script: devtools::load_all(); barret() |> runApp(port = 8080)After clicking a few times... logfire gives this output: 
|
* main: preemptively run revdepcheck. 5 failures. fix(scss): Remove updated scss files and restore R sass compilation (#4272)
…cent one is evaluated last
|
After live discussion with @schloerke:
|
… within the Shiny package
Using rstudio/promises#176, ✅ within Shiny. Works great! 🥳🥳 |
* main: update docs (#4285)
…passing weather chat app demo
schloerke
commented
Sep 18, 2025
R/otel.R
Outdated
| if (!is.null(tracer)) { | ||
| return(tracer) | ||
| } | ||
| if (testthat::is_testing()) { |
There was a problem hiding this comment.
Must also check if testthat is installed. No need to use a perfect / fast reproducible call here as it is only possibly repeated during testing.
Refactored label assignment to use rassignSrcrefToLabel for both reactiveVal and reactiveValues, ensuring a sensible default label is used when the assigned name cannot be easily determined from srcref. This change improves robustness and consistency in labeling reactive objects.
…. Makes otel clean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #4258
Fixes #4265 -
bindOtel(x),withOtel(expr, ..., bind = "all")Fixes #4268 -
options(shiny.otel.bind = "all")(and"none")Possible future support:
Fixes #4268 -
options(shiny.otel.bind = c("reactiveVal", "reacitveValues", "reactiveExpr", "observe", "output")Fixes #4266 -
options(shiny.otel.bind = "reactive-update")Fixes #4282 -
options(shiny.otel.binnd = "session")