-
Notifications
You must be signed in to change notification settings - Fork 58
Connect quarto version #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@dbkegley is this dangerous to do mid-release? |
|
Yes, sadly. The Connect helm chart also depends the specific version of quarto: https://github.com/rstudio/helm/blob/72ff22a35496fa46780c48084be3457b8fd4b721/charts/rstudio-connect/values.yaml#L420-L425 Bumping the quarto/r/python version mid-release would break the helm chart because the default configs wouldn't align: https://github.com/rstudio/helm/blob/72ff22a35496fa46780c48084be3457b8fd4b721/Justfile#L89-L118 We typically try to release interpreter version updates at the same time as a product release to avoid migration issues for customers |
|
There's a connect release happening soon, do we still want to bump the quarto version? There's also #938 which adds an image with quarto 1.7. Is one image sufficient? |
|
My #938 PR adds a content image and does not adjust the Quarto, R, or Python versions included in the Connect image. |
|
@markrtucker is this still necessary? If so, can we apply it to the latest product version and images? |
The Chronicle team would still like this. For context, PTD uses these docker images and the Chronicle Cookbook requires Quarto 1.5.x-ish. This means that we cannot publish the Cookbook with source code to Connect in PTD. I don't fully understand the concerns noted above by @dbkegley, so I don't know how to adequately address those concerns. Ultimately, we would like to see the connect docker image include a recent version of quarto (1.4 is about 18 months old at this point). |
The quarto version defined in the Connect image is used by customers who run Connect with local execution. If we bump the quarto version in the official connect image then it will break customer installations with existing configurations referencing quarto v1.4.557. This is why we typically bump the default r/python/quarto installations in conjunction with a Connect release because it means that we won't push a breaking change to an existing image tag. Doesn't PTD use off-host execution? If so then could you add a new execution environment using one of the images available under the https://github.com/rstudio/rstudio-docker-products/pkgs/container/content-base |
@stevenolen - any thoughts on this? |
|
I don't see any problem with this. Is this configurable via the connect UI, or in config files? |
execution environments are configurable via the UI or server API. They can also be configured automatically during the first server start with the Bootstrap on first start: Server API: |
@bschwedler / @ianpittwood - the purpose here is to update the Quarto version that is bundled in the Connect docker image, with the ultimate goal of getting a newer Quarto version deployed in PTD. (The 1.4.557 version that is currently bundled is not compatible with the Chronicle Cookbook.)
I'm not overly familiar with the details of this repo, so asking for a preliminary review from you before officially marking this as ready for review.