Skip to content

fixed dot and bracket accessors on immediate numbers #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wkornewald wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed dot and bracket accessors on immediate numbers #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/slimit/tests/test_minifier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,14 @@ def assertMinified(self, source, expected):
""",
"(function($){$.hello='world';}(jQuery));"),

# function call on immediate number
('((25)).toString()', '(25).toString();'),
('((25))["toString"]()', '(25).toString();'),

# attribute access on immediate number
('((25)).attr', '(25).attr;'),
('((25))["attr"]', '(25).attr;'),

# function call in FOR init
('for(o(); i < 3; i++) {}', 'for(o();i<3;i++){}'),

Expand Down
5 changes: 4 additions & 1 deletion src/slimit/visitors/ecmavisitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,10 @@ def visit_DotAccessor(self, node):
template = '(%s.%s)'
else:
template = '%s.%s'
s = template % (self.visit(node.node), self.visit(node.identifier))
left = self.visit(node.node)
if isinstance(node.node, ast.Number):
left = '(%s)' % left
s = template % (left, self.visit(node.identifier))
return s

def visit_BracketAccessor(self, node):
Expand Down
10 changes: 8 additions & 2 deletions src/slimit/visitors/minvisitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,10 @@ def visit_DotAccessor(self, node):
template = '(%s.%s)'
else:
template = '%s.%s'
s = template % (self.visit(node.node), self.visit(node.identifier))
left = self.visit(node.node)
if isinstance(node.node, ast.Number):
left = '(%s)' % left
s = template % (left, self.visit(node.identifier))
return s

def visit_BracketAccessor(self, node):
Expand All @@ -400,7 +403,10 @@ def visit_BracketAccessor(self, node):
elif value.startswith('"'):
value = value.strip('"')
if _is_identifier(value):
s = '%s.%s' % (self.visit(node.node), value)
left = self.visit(node.node)
if isinstance(node.node, ast.Number):
left = '(%s)' % left
s = '%s.%s' % (left, value)
return s

s = '%s[%s]' % (self.visit(node.node), self.visit(node.expr))
Expand Down