Bugfix for "Payload.fromJson" factory method#29
Closed
stephanfeb wants to merge 1 commit intorsocket:masterfrom
stephanfeb:payload-bugfix
Closed
Bugfix for "Payload.fromJson" factory method#29stephanfeb wants to merge 1 commit intorsocket:masterfrom stephanfeb:payload-bugfix
stephanfeb wants to merge 1 commit intorsocket:masterfrom
stephanfeb:payload-bugfix
Conversation
- bug : the payload.data is incorrectly assigned to the metadata field. - This PR: Corrects the assignment in the factory method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BugFix. Payload data is populated with metadata
Motivation:
It's a bug.
Instead of assigning payload data to the
Payload.datafield, it is instead incorrectly assigned to the metadata field.Modifications:
Corrected the field assignment.
Result:
The payload data is now assigned to the correct field.