-
Notifications
You must be signed in to change notification settings - Fork 19
feat: add config command for CLI configuration management with intera… #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add config command for CLI configuration management with intera… #198
Conversation
…ctive settings, gas/network defaults, API keys, display preferences, wallet options, and JSON persistence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pranavkonde
I liked the idea, and I have a few suggestions:
-
We need the proposed new configuration to be implemented in the commands.
-
Please remember not only to make the implementation but also to update the README, documenting these new options.
-
Also, please review the other comments I left in the PR.
Thanks!
hey @pranavkonde, the readme looks really good and also I checked that the cyan dividers are away :) Let’s get this aligned so we can merge your PR and move forward with the reward — thanks! We’ll need you to implement the use of the saved configurations in at least a few commands to make this contribution meaningful. Also, just a heads-up: we've been merging PRs from other contributors and adding support for MCP, so you'll need to resolve the conflicts as well. We’ll definitely keep all of this in mind when it comes to your reward. |
…ature/add-config-command
I’ve made the suggested changes. Everything should now be in sync and ready for review. |
Fixing visible sensitive information
Just for security purposes not showing any part of the api key
Hello @pranavkonde , I did a small change to protect the alchemy api key (requested by codeql) |
…ature/add-config-command
…vkonde/rsk-cli into feature/add-config-command
…tion, deploy, bridge, balance, verify)
Hello @scguaquetam |
Hello @pranavkonde , thanks for the changes. Additionally, when I tested the deploy command, it shows an error when trying to deploy a contract, looks like your implementation is breaking the function, because it does not work with and without the |
Thank you for catching these issues! I've made the following fixes |
Hello @pranavkonde I am a little bit confused here
Doesn't should all the implementations have the same fix? |
Hello @scguaquetam |
I see this contribution correct, I don't see errors, just a question I have on the transaction module, which @pranavkonde created previously (If you @pranavkonde can fix it and configure |
Thanks for the review! I’ve made the requested changes and updated the transaction module accordingly, connecting it with the |
@scguaquetam Thank you for catching these issues! I've made the following fixes |
Add Config Command for CLI Configuration Management
Overview
Added a comprehensive configuration management system to the RSK CLI, allowing users to customize their CLI experience through an interactive configuration command.
Features Added
Interactive Configuration Management
Technical Implementation
rsk-cli-config.json
User Experience
Configuration Options