Consider segwit when checking for standard max tx size #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TransactionWitness
…hForWitnessSignature
…gwitWithP2shRedeemScript_withTwoSignatures_shouldReturnIndexCorrectly
…o they were extracted. Besides different test cases were added
…dded this and simplified a lot the code
…sFilledWithSignatures_shouldReturnTheProperIndex test
… or output script
…ript by ScriptBuilder depending on the number of keys
…d) for createMultiSigOutputScript
Co-authored-by: julia zack <[email protected]>
….java Co-authored-by: julia zack <[email protected]>
…ate castToBigInteger in ScriptChunk class to avoid circular dependency with Script class
…n 4 bytes. Refactor
julia-zack
commented
Jul 4, 2025
| // assert | ||
| double expectedSize = 375; | ||
| double realSize = 375; | ||
| int expectedCalculatedSize = 340; |
There was a problem hiding this comment.
value obtained from base branch, before the changes
julia-zack
commented
Jul 4, 2025
| // assert | ||
| double expectedSize = 183.75; | ||
| double realSize = 183.75; | ||
| int expectedCalculatedSize = 184; |
There was a problem hiding this comment.
value obtained from base branch, before the changes
julia-zack
force-pushed
the
consider_segwit_when_checking_for_standard_max_tx_size
branch
from
3c76532 to
8807a5a
Compare
marcos-iov
force-pushed
the
segwit_compatible_powpeg_integration_part2
branch
from
4d4262d to
d39fbbb
Compare
Base automatically changed from
segwit_compatible_powpeg_integration_part2
to
master
July 23, 2025 15:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.