Skip to content

Suppress libusb compile warnings - #35

Open
stefan-sherwood wants to merge 1 commit into
rsjudka:developfrom
stefan-sherwood:patch-1
Open

Suppress libusb compile warnings#35
stefan-sherwood wants to merge 1 commit into
rsjudka:developfrom
stefan-sherwood:patch-1

Conversation

@stefan-sherwood

Copy link
Copy Markdown

This same change can also be done for subprojects aasdk/ and openauto/ though I'm not sure the correct protocol for doing that.

@rsjudka

rsjudka commented May 25, 2020

Copy link
Copy Markdown
Owner

this seems like more of a hack doesn't it?

I think a cleaner way of fixing this would be done something like this: https://github.com/openDsh/aasdk/pull/2/files (just look specifically at the libusb stuff but you could always bring the other fixes in too)

@stefan-sherwood

Copy link
Copy Markdown
Author

I must be misunderstanding, It looks like the include isn't needed, in which case the library could also be removed. But if it is needed, it doesn't look like that fix would work.

(I assumed it was being used)

@rsjudka

rsjudka commented May 25, 2020

Copy link
Copy Markdown
Owner

there is an include, it just moved to the Findlibusb-1.0.cmake module

@stefan-sherwood

Copy link
Copy Markdown
Author

Ah, now I see it. The fix amounts to the same thing as mine. It suppresses warnings because it's labeled as a system include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants