Add optional argument to reconnect for Rails 7.1+ compatibility #2433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2432
ActiveRecord.connection.verify!
fails on Rails 7.1.0+ when reconnection is needed, because Rails 7.1 added an optional argumentrestore_transactions: false
to the#reconnect!
method which is used e.g. inside the#verify!
This change has been implemented in rails/rails#44573 and it appeared in Rails
7.1.0beta1
for the first time.Oracle Enhanced Driver Implementation
oracle-enhanced/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb
Lines 470 to 475 in d5b3daf
Rails 7.1.0beta1 Implementation
https://github.com/rails/rails/blob/2d7bc98897053658ad904b12e5b19a52b8cc3617/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb#L560-L565
Rails 7.1.5.1 Implementation
https://github.com/rails/rails/blob/14c115b120ed089331ff3dc13f36bd9129ced33d/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb#L680-L712