Skip to content
This repository was archived by the owner on Oct 23, 2022. It is now read-only.

Start tracking changelog #400

Merged
merged 3 commits into from
Oct 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@
- [ ] Each command has a usage example and API specification
- [ ] Rustdoc tests are passing on all code-level comments
- [ ] Differences between Rust’s IPFS implementation and the Go or JS implementations are explained
- [ ] Additions to CHANGELOG.md files
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Next

# 0.2.0

First real release, with big changes and feature improvements. Started tracking
a changelog.
38 changes: 38 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,49 @@ Following these principles in your PRs will greatly increase your chances of a s

1. Keep the patch size minimal
2. Aim for high (but not absolute) code coverage in testing
3. Add a note in the changelog(s)

By keeping the patch size minimal we hope to avoid difficult to review situations where there are lot of lines changed with only a few necessary changes. If you wish to submit a pull request for reorganizing something, please keep all unnecessary changes out.

For example, if you wanted to change the wording of this CONTRIBUTING.md file and dislike the fact that there is no static word wrap used, please push two separate pull requests to first change the wording, and finally to reformat the file.

### Changelogs and their format

We currently maintain two CHANGELOG files:

* [`CHANGELOG.md`](./CHANGELOG.md)
* [`unixfs/CHANGELOG.md`](./unixfs/CHANGELOG.md)

If your PR includes changes to `unixfs/`, include a note in the
`unixfs/CHANGELOG.md`. If your PR includes changes elsewhere, include a note in
the root `CHANGELOG.md`.

The changelog format we've used so far in `unixfs/CHANGELOG.md` is:

```
# {release version}

Short overview.

* Short overview [#PR_NUMBER]

[#PR_NUMBER]: PR_URL
```

If you find yourself writing list of things, just make it multiple items in the
list, like:

```
* Short overview, part of [#PR_NUMBER]
* Another thing, part of [#PR_NUMBER]

[#PR_NUMBER]: PR_URL
```

In the changelog the most recently released version should be first. This
changelog format is more free-form than the more familiar separation of fixes
and features. We will probably later migrate to more detailed changelogs.

## Target Build

Rust IPFS will always target the current _stable_ version of Rust that is released. Our CI/CD tests will reflect this. See [instructions here on how to install the rust toolchain](https://doc.rust-lang.org/book/ch01-01-installation.html).
Expand Down
2 changes: 2 additions & 0 deletions unixfs/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# Next

# 0.2.0

Minor version bump due to ipfs 0.2.0 release.
Expand Down