This repository was archived by the owner on Oct 23, 2022. It is now read-only.
remove unimplemented ipns functionalities from Ipfs #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ljedrz <[email protected]>
koivunej
suggested changes
Sep 22, 2020
There was a problem hiding this comment.
So this would leave us:
- I see the
ipfs::Ipns::resolveis different fromIpfs::resolve_ipns - insert and cancel are removed,
src/ipns/mod.rsbecomes unnecessary except fordns ipfs::ipns::dnsshould probably bednslink?- build.rs compiles
src/ipns/ipns_pb.protofor no reason, could be removed, but maybe the file be retained? - example is now worthless, could be removed
Perhaps the src/ipns/mod.rs should be cleaned up to contain only comment on why it was removed? Or then just retain the current structure with struct Ipns and move the resolving method from Ipfs::resolve_ipns to it.
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
Signed-off-by: ljedrz <[email protected]>
koivunej
approved these changes
Sep 22, 2020
|
bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ipns insertion and cancellation features from
ipfs::Ipfs(they are not implemented).Cc #356