Skip to content

Conversation

eoghanmurray
Copy link
Contributor

Leverage monkeypatching on addShadowRoot to save a reference to the mode:closed shadow roots, and record them just like open ones

… mode:closed shadow roots, and record them just like open ones
Copy link

changeset-bot bot commented Sep 12, 2025

🦋 Changeset detected

Latest commit: 5889179

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@eoghanmurray
Copy link
Contributor Author

If a reviewer dislikes the addition of __rrClosedShadowRoot attributes on elements with closed shadow roots, the remedy would be to move dom.shadowRoot to ShadowDomManager.shadowRoot and pass a reference to shadowDomManager into the rrweb-snapshot/snapshot.ts serialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant