fix JSON stats view and tests with redis-py 6.0 #706
Conversation
terencehonles
force-pushed
the
fix-redis-py-retry-change
branch
2 times, most recently
from
c2e9a28 to
1e6ac48
Compare
terencehonles
changed the title
| connection_kwargs.pop('connection_pool', None) | ||
| connection_kwargs.pop('parser_class', None) | ||
| connection_kwargs.pop('retry', None) |
There was a problem hiding this comment.
Do we want to try to serialize this?
django_rq/tests/utils.py
Outdated
| special_case_retry = False | ||
| if (retry := connection_kwargs.get('retry')) and retry.__class__.__eq__ == object.__eq__: | ||
| special_case_retry = True | ||
| del connection_kwargs['retry'] |
There was a problem hiding this comment.
Special casing can be removed if redis/redis-py#3628 is accepted and released in a minor / point release and we don't need to support all previous releases (or the support for 6.0 is dropped, which will probably be in a long time)
There was a problem hiding this comment.
It seems like your PR was merged yesterday. redis/redis-py#3628 . Should we just wait for redis-py 6.0.1 to be released before merging this in?
There was a problem hiding this comment.
Up to you, not sure how long that will be
There was a problem hiding this comment.
I think I might just exclude redis-py 6.0 from dependency. Will cut a release soon.
There was a problem hiding this comment.
I'll update this to not have the workaround then. I'm assuming you will have something like redis-py!=6.0.0 in the dependency specifiers, so that when 6.0.1 is released this will work properly still.
There was a problem hiding this comment.
Yes, I merged this in just a few minutes ago: rq/rq#2244
There was a problem hiding this comment.
Ok, I updated this PR for you
terencehonles
force-pushed
the
fix-redis-py-retry-change
branch
2 times, most recently
from
26fdc80 to
1fc2df7
Compare
terencehonles
force-pushed
the
fix-redis-py-retry-change
branch
from
1fc2df7 to
a1c3093
Compare
| queue_index = i | ||
| break | ||
| return queue_index | ||
| if q.name == name: |
There was a problem hiding this comment.
I updated this to only check the name, since this method was skipping the queue (and breaking on an IndexError if the connection wasn't the "same")
x-ref: redis/redis-py#3614
x-ref: redis/redis-py#3622