Do not fail in lr_prepare_repodata_dir() if repodata/ dir exists #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If mkdir() fails and errno is EEXIST, that's ok. It means we already
have the repodata/ directory. Just keep going. But any other errors
get reported and the function fails.
Fixing this fixes the problem I've been seeing on my system ever since
moving to dnf5, which is:
$ sudo dnf check-update
# ERROR: something about directory already existing
# argh..., so then do
$ sudo dnf clean all
$ sudo dnf check-update
Now I can just do 'sudo dnf check-update' and it works. I am seeing
this on Fedora 42 right now, but I also saw it on previous releases.
Signed-off-by: Dave Cantrell <[email protected]>
Contributor
|
I also agree this is a fine change I am only curious if you could share some more details regarding the reproducer? It doesn't happen to me using the steps you described and I would like understand how it can happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If mkdir() fails and errno is EEXIST, that's ok. It means we already have the repodata/ directory. Just keep going. But any other errors get reported and the function fails.
Fixing this fixes the problem I've been seeing on my system ever since moving to dnf5, which is:
Now I can just do 'sudo dnf check-update' and it works. I am seeing this on Fedora 42 right now, but I also saw it on previous releases.