Skip to content

feat: pass argument to main function #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat: pass argument to main function #5

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b2cab46
feat: pass argument to main function
saintsebastian Jul 24, 2017
12be9ae
move checking for argument into wrapper
saintsebastian Jul 25, 2017
2e41028
better handled errors
saintsebastian Jul 27, 2017
63916af
feat: add expected erro class and its handling
saintsebastian Aug 7, 2017
9b9e16c
test: initial test for onlyInstancesOf
saintsebastian Aug 7, 2017
1457b19
fix: cleanup and better syntax
saintsebastian Aug 10, 2017
441432b
test: initial test for main
saintsebastian Aug 11, 2017
1f936d1
test: unit tests for main
saintsebastian Aug 14, 2017
599396d
fix: reviewed tests for index
saintsebastian Sep 3, 2017
2f52f91
test: separate dependencies for main into module
saintsebastian Sep 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/create-webextension
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#!/usr/bin/env node

require("..").main();
require("..").main(process.argv[2]);
6 changes: 3 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,14 @@ function getProjectManifest(projectDirName) {
};
}

exports.main = function main() {
if (!process.argv[2]) {
exports.main = function main(dirPath) {
if (!dirPath) {
console.error(`${chalk.red("Missing project dir name.")}\n`);
console.log(USAGE_MSG);
process.exit(1);
Copy link
Owner

@rpl rpl Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saintsebastian a process.exit(...) when using this package as a library is super annoying (as well as logging on the console), we can throw an Error instance from here and move the process.exit(...) and the logging in the CLI wrapper that we have in "bin/create-webextension", how that sounds to you?

}

const projectPath = path.resolve(process.argv[2]);
const projectPath = path.resolve(dirPath);
const projectDirName = path.basename(projectPath);

return fs.mkdir(projectPath).then(() => {
Expand Down