feat(auth-files): priority display, sorting & credential notes#149
feat(auth-files): priority display, sorting & credential notes#149RGBadmin wants to merge 2 commits intorouter-for-me:mainfrom
Conversation
- Show priority value on AuthFileCard when the credential has a priority field - Add sort dropdown (Default / A-Z Name / Priority) to the credentials list - Priority sort orders credentials from highest to lowest - Add i18n translations for zh-CN, en, and ru Co-Authored-By: Claude Opus 4.6 <[email protected]>
- Add note field to the credential field editor (PrefixProxyEditorModal) - Store note as a string in the credential JSON file - Display note on AuthFileCard with 2-line clamp for long text - Note is saved when non-empty, removed from JSON when cleared - Add i18n translations for zh-CN, en, and ru Co-Authored-By: Claude Opus 4.6 <[email protected]>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience of the Auth Files credential management page by integrating new features for better organization and information access. Users can now easily identify credential priorities, arrange their files using various sorting options, and add descriptive notes to each credential. These additions aim to streamline credential management and provide more contextual information directly within the UI. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces priority display, sorting capabilities, and credential notes to the Auth Files management page. The changes are well-implemented across the UI components, state management hooks, and internationalization files. The new features are valuable additions for managing authentication credentials. I have included a couple of minor suggestions to enhance code clarity by removing redundant expressions. Overall, this is a well-executed enhancement.
| const hasStatusWarning = | ||
| Boolean(rawStatusMessage) && !HEALTHY_STATUS_MESSAGES.has(rawStatusMessage.toLowerCase()); | ||
|
|
||
| const priorityValue = parsePriorityValue(file.priority ?? file['priority']); |
There was a problem hiding this comment.
The expression file.priority ?? file['priority'] is redundant. Accessing a property with dot notation (file.priority) is equivalent to using bracket notation (file['priority']) for a valid identifier. You can simplify this for better readability.
| const priorityValue = parsePriorityValue(file.priority ?? file['priority']); | |
| const priorityValue = parsePriorityValue(file.priority); |
| const pa = parsePriorityValue(a.priority ?? a['priority']) ?? 0; | ||
| const pb = parsePriorityValue(b.priority ?? b['priority']) ?? 0; |
There was a problem hiding this comment.
The expressions a.priority ?? a['priority'] and b.priority ?? b['priority'] are redundant. Accessing a property with dot notation is equivalent to bracket notation for valid identifiers. You can simplify this for better readability.
| const pa = parsePriorityValue(a.priority ?? a['priority']) ?? 0; | |
| const pb = parsePriorityValue(b.priority ?? b['priority']) ?? 0; | |
| const pa = parsePriorityValue(a.priority) ?? 0; | |
| const pb = parsePriorityValue(b.priority) ?? 0; |
1 participant
概述 / Summary
为 Auth Files 凭证管理页面添加三项功能：优先级展示、排序支持、凭证备注。
Adds three features to the Auth Files credential management page: priority display, sorting support, and credential notes.
功能详情 / Features
1. 优先级展示 / Priority display
2. 排序支持 / Sorting support
3. 凭证备注 / Credential notes
note字段中notestring in the credential JSON file4. 国际化 / i18n
改动文件 / Changed files
AuthFileCard.tsxAuthFilesPage.tsxAuthFilesPage.module.scssAuthFilesPrefixProxyEditorModal.tsxuseAuthFilesPrefixProxyEditor.tszh-CN.json/en.json/ru.json测试计划 / Test plan
🤖 Generated with Claude Code