feat(api): expose priority and note in GET /auth-files response #2124
+280
−6
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -744,3 +744,200 @@ func TestBuildGeminiVirtualID(t *testing.T) { | |
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestSynthesizeGeminiVirtualAuths_NotePropagated(t *testing.T) { | ||
| now := time.Now() | ||
| primary := &coreauth.Auth{ | ||
| ID: "primary-id", | ||
| Provider: "gemini-cli", | ||
| Label: "[email protected]", | ||
| Attributes: map[string]string{ | ||
| "source": "test-source", | ||
| "path": "/path/to/auth", | ||
| "priority": "5", | ||
| "note": "my test note", | ||
| }, | ||
| } | ||
| metadata := map[string]any{ | ||
| "project_id": "proj-a, proj-b", | ||
| "email": "[email protected]", | ||
| "type": "gemini", | ||
| } | ||
|
|
||
| virtuals := SynthesizeGeminiVirtualAuths(primary, metadata, now) | ||
|
|
||
| if len(virtuals) != 2 { | ||
| t.Fatalf("expected 2 virtuals, got %d", len(virtuals)) | ||
| } | ||
|
|
||
| for i, v := range virtuals { | ||
| if got := v.Attributes["note"]; got != "my test note" { | ||
| t.Errorf("virtual %d: expected note %q, got %q", i, "my test note", got) | ||
| } | ||
| if got := v.Attributes["priority"]; got != "5" { | ||
| t.Errorf("virtual %d: expected priority %q, got %q", i, "5", got) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func TestSynthesizeGeminiVirtualAuths_NoteAbsentWhenEmpty(t *testing.T) { | ||
| now := time.Now() | ||
| primary := &coreauth.Auth{ | ||
| ID: "primary-id", | ||
| Provider: "gemini-cli", | ||
| Label: "[email protected]", | ||
| Attributes: map[string]string{ | ||
| "source": "test-source", | ||
| "path": "/path/to/auth", | ||
| }, | ||
| } | ||
| metadata := map[string]any{ | ||
| "project_id": "proj-a, proj-b", | ||
| "email": "[email protected]", | ||
| "type": "gemini", | ||
| } | ||
|
|
||
| virtuals := SynthesizeGeminiVirtualAuths(primary, metadata, now) | ||
|
|
||
| if len(virtuals) != 2 { | ||
| t.Fatalf("expected 2 virtuals, got %d", len(virtuals)) | ||
| } | ||
|
|
||
| for i, v := range virtuals { | ||
| if _, hasNote := v.Attributes["note"]; hasNote { | ||
| t.Errorf("virtual %d: expected no note attribute when primary has no note", i) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func TestFileSynthesizer_Synthesize_NoteParsing(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| note any | ||
| want string | ||
| hasValue bool | ||
| }{ | ||
| { | ||
| name: "valid string note", | ||
| note: "hello world", | ||
| want: "hello world", | ||
| hasValue: true, | ||
| }, | ||
| { | ||
| name: "string note with whitespace", | ||
| note: " trimmed note ", | ||
| want: "trimmed note", | ||
| hasValue: true, | ||
| }, | ||
| { | ||
| name: "empty string note", | ||
| note: "", | ||
| hasValue: false, | ||
| }, | ||
| { | ||
| name: "whitespace only note", | ||
| note: " ", | ||
| hasValue: false, | ||
| }, | ||
| { | ||
| name: "non-string note ignored", | ||
| note: 12345, | ||
| hasValue: false, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| tempDir := t.TempDir() | ||
| authData := map[string]any{ | ||
| "type": "claude", | ||
| "note": tt.note, | ||
| } | ||
| data, _ := json.Marshal(authData) | ||
| errWriteFile := os.WriteFile(filepath.Join(tempDir, "auth.json"), data, 0644) | ||
| if errWriteFile != nil { | ||
| t.Fatalf("failed to write auth file: %v", errWriteFile) | ||
| } | ||
|
|
||
| synth := NewFileSynthesizer() | ||
| ctx := &SynthesisContext{ | ||
| Config: &config.Config{}, | ||
| AuthDir: tempDir, | ||
| Now: time.Now(), | ||
| IDGenerator: NewStableIDGenerator(), | ||
| } | ||
|
|
||
| auths, errSynthesize := synth.Synthesize(ctx) | ||
| if errSynthesize != nil { | ||
| t.Fatalf("unexpected error: %v", errSynthesize) | ||
| } | ||
| if len(auths) != 1 { | ||
| t.Fatalf("expected 1 auth, got %d", len(auths)) | ||
| } | ||
|
|
||
| value, ok := auths[0].Attributes["note"] | ||
| if tt.hasValue { | ||
| if !ok { | ||
| t.Fatal("expected note attribute to be set") | ||
| } | ||
| if value != tt.want { | ||
| t.Fatalf("expected note %q, got %q", tt.want, value) | ||
| } | ||
| return | ||
| } | ||
| if ok { | ||
| t.Fatalf("expected note attribute to be absent, got %q", value) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func TestFileSynthesizer_Synthesize_MultiProjectGeminiWithNote(t *testing.T) { | ||
| tempDir := t.TempDir() | ||
|
|
||
| authData := map[string]any{ | ||
| "type": "gemini", | ||
| "email": "[email protected]", | ||
| "project_id": "project-a, project-b", | ||
| "priority": 5, | ||
| "note": "production keys", | ||
| } | ||
| data, _ := json.Marshal(authData) | ||
| err := os.WriteFile(filepath.Join(tempDir, "gemini-multi.json"), data, 0644) | ||
| if err != nil { | ||
| t.Fatalf("failed to write auth file: %v", err) | ||
| } | ||
|
|
||
| synth := NewFileSynthesizer() | ||
| ctx := &SynthesisContext{ | ||
| Config: &config.Config{}, | ||
| AuthDir: tempDir, | ||
| Now: time.Now(), | ||
| IDGenerator: NewStableIDGenerator(), | ||
| } | ||
|
|
||
| auths, err := synth.Synthesize(ctx) | ||
| if err != nil { | ||
| t.Fatalf("unexpected error: %v", err) | ||
| } | ||
| // Should have 3 auths: 1 primary (disabled) + 2 virtuals | ||
| if len(auths) != 3 { | ||
| t.Fatalf("expected 3 auths (1 primary + 2 virtuals), got %d", len(auths)) | ||
| } | ||
|
|
||
| primary := auths[0] | ||
| if gotNote := primary.Attributes["note"]; gotNote != "production keys" { | ||
| t.Errorf("expected primary note %q, got %q", "production keys", gotNote) | ||
| } | ||
|
|
||
| // Verify virtuals inherit note | ||
| for i := 1; i < len(auths); i++ { | ||
| v := auths[i] | ||
| if gotNote := v.Attributes["note"]; gotNote != "production keys" { | ||
| t.Errorf("expected virtual %d note %q, got %q", i, "production keys", gotNote) | ||
| } | ||
| if gotPriority := v.Attributes["priority"]; gotPriority != "5" { | ||
| t.Errorf("expected virtual %d priority %q, got %q", i, "5", gotPriority) | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the auth manager is unavailable, the fallback path now emits
priorityfor any file that merely has aprioritykey, butgjson.Int()coerces non-numeric values (for example"priority":"high"or"priority":null) to0. This makes the API report a concrete priority that was never configured and can change sort/order behavior in degraded mode, while the normal in-memory path only includesprioritywhen integer parsing succeeds.Useful? React with 👍 / 👎.