Skip to content

feat(service): extend model registration for team and business types #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luispater merged 1 commit into from
Mar 14, 2026
Merged

feat(service): extend model registration for team and business types #2110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/cliproxy/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,7 +883,7 @@ func (s *Service) registerModelsForAuth(a *coreauth.Auth) {
models = registry.GetCodexProModels()
case "plus":
models = registry.GetCodexPlusModels()
case "team":
case "team", "business":
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this change correctly handles the 'business' plan type, this part of the model registration logic appears to be untested. To ensure the correctness of this new addition and prevent future regressions, it would be beneficial to add a unit test.

You could create a test that:

  1. Initializes a Service.
  2. Creates a coreauth.Auth object with Provider: "codex" and Attributes: map[string]string{"plan_type": "business"}.
  3. Calls service.registerModelsForAuth() with this auth object.
  4. Asserts that the models from registry.GetCodexTeamModels() are registered for the auth ID in the GlobalModelRegistry().

This would provide good test coverage for the change.

models = registry.GetCodexTeamModels()
case "free":
models = registry.GetCodexFreeModels()
Expand Down
Loading