-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: add configurable messages-path for Claude upstream (fixes #2055) #2063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
admccc
wants to merge
13
commits into
router-for-me:main
Choose a base branch
from
admccc:fix/claude-base-url-v1-normalization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+172
−3
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2a6ad7b
fix: normalize claude base URL to support /v1 suffix in relay services
admccc e293e6c
test: add TestNormalizeClaudeBaseURL for base URL normalization
admccc 86b6cc4
fix: replace hardcoded /v1/messages with configurable messages-path
admccc fbbdf2d
test: replace TestNormalizeClaudeBaseURL with TestClaudeMessagesPath
admccc 197b4ba
feat: add messages-path field to ClaudeKey config
admccc 500c6e5
feat: propagate messages_path attribute from ClaudeKey config to auth
admccc 245ae8b
docs: document messages-path option for claude-api-key config
admccc b65076d
feat: support messages-path in Claude key management API
admccc 318161a
feat: display messages-path in TUI keys tab for Claude keys
admccc a1e9f07
fix: normalize base URL and messages-path to prevent malformed URLs
admccc a26a653
test: add TestNormalizeBaseURL and expand TestClaudeMessagesPath
admccc 6bc4425
fix: normalize messages-path in management API (enforce leading /, tr…
admccc 0cbbe77
fix: normalize messages-path in synthesizer (enforce leading /, trim …
admccc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
TrimSuffixcall that removes/v1from thebaseURLis too aggressive and may lead to incorrect URLs when combined with the newmessages-pathfeature.As per the PR description, a user might configure a
base-urlthat includes a version path and usemessages-pathfor the final segment. For instance:The expected final URL is
https://new-api.example.com/v1/messages. However, this function will strip/v1, resulting in an incorrect URL:https://new-api.example.com/messages.To ensure user configurations are respected, it would be safer to only trim the trailing slash from the base URL. The logic that constructs the final URL should be responsible for handling path segments correctly.