Skip to content

fix: suppress token refresh write-back loop and reduce log noise #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YoungMoneyInvestments wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

fix: suppress token refresh write-back loop and reduce log noise #1943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/api/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,7 +993,7 @@ func (s *Server) UpdateClients(cfg *config.Config) {
}

total := authEntries + geminiAPIKeyCount + claudeAPIKeyCount + codexAPIKeyCount + vertexAICompatCount + openAICompatCount
fmt.Printf("server clients and configuration updated: %d clients (%d auth entries + %d Gemini API keys + %d Claude API keys + %d Codex keys + %d Vertex-compat + %d OpenAI-compat)\n",
log.Debugf("server clients and configuration updated: %d clients (%d auth entries + %d Gemini API keys + %d Claude API keys + %d Codex keys + %d Vertex-compat + %d OpenAI-compat)",
total,
authEntries,
geminiAPIKeyCount,
Expand Down
7 changes: 6 additions & 1 deletion sdk/cliproxy/auth/conductor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2159,7 +2159,12 @@ func (m *Manager) refreshAuth(ctx context.Context, id string) {
updated.NextRefreshAfter = time.Time{}
updated.LastError = nil
updated.UpdatedAt = now
_, _ = m.Update(ctx, updated)
// Use WithSkipPersist to avoid writing the refreshed token back to disk.
// The in-memory state is already updated; persisting here would trigger
// the file watcher, which calls reloadCallback -> UpdateClients, creating
// a write-back feedback loop that spams the log with "configuration updated"
// messages every ~1 minute per token.
_, _ = m.Update(WithSkipPersist(ctx), updated)
}

func (m *Manager) executorFor(provider string) ProviderExecutor {
Expand Down